Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: Eyal Shapira <eyal@wizery.com>, linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters
Date: Tue, 08 Nov 2011 16:06:28 +0200	[thread overview]
Message-ID: <1320761188.19479.10.camel@cumari> (raw)
In-Reply-To: <1320760486-19700-1-git-send-email-eyal@wizery.com>

On Tue, 2011-11-08 at 15:54 +0200, Eyal Shapira wrote: 
> A minor fix for the check that verifies that all given SSIDs (in req) exist
> in the filters (the match sets)
> 
> Signed-off-by: Eyal Shapira <eyal@wizery.com>
> ---
>  drivers/net/wireless/wl12xx/scan.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/wl12xx/scan.c b/drivers/net/wireless/wl12xx/scan.c
> index 128ccb7..fc29c67 100644
> --- a/drivers/net/wireless/wl12xx/scan.c
> +++ b/drivers/net/wireless/wl12xx/scan.c
> @@ -559,7 +559,7 @@ wl12xx_scan_sched_scan_ssid_list(struct wl1271 *wl,
>  						break;
>  					}
>  				/* Fail if SSID isn't present in the filters */
> -				if (j == req->n_ssids) {
> +				if (j == cmd->n_ssids) {
>  					ret = -EINVAL;
>  					goto out_free;
>  				}

Just to clarify.  My comment:
> Acked-by: Luciano Coelho <coelho@ti.com>
> 
> John, can you apply this to 3.2, please?

...was about this patch.  Eyal's email was delivered to me, but vger
rejected it, so he had to resend it.

-- 
Cheers,
Luca.


  reply	other threads:[~2011-11-08 14:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 13:54 [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters Eyal Shapira
2011-11-08 14:06 ` Luciano Coelho [this message]
2011-11-08 14:09   ` John W. Linville
     [not found] <1320756132-14625-1-git-send-email-eyal@wizery.com>
2011-11-08 12:47 ` Luciano Coelho
2011-11-08 14:08   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320761188.19479.10.camel@cumari \
    --to=coelho@ti.com \
    --cc=eyal@wizery.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox