linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFT/FYI] mac80211: revert on-channel work optimisations
Date: Tue, 08 Nov 2011 18:18:47 +0100	[thread overview]
Message-ID: <1320772727.24797.23.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4EB96416.5040700@candelatech.com>

On Tue, 2011-11-08 at 09:17 -0800, Ben Greear wrote:
> On 11/08/2011 09:10 AM, Johannes Berg wrote:
> > FYI -- I'm going to test this a bit more but I am going to put it in.
> > The code is a mess -- look at how much code I remove below (and that's
> > after everybody elses cleanups!) for a dubious optimisation.
> >
> > I agree that we should address this and we need to really do this to not
> > mess up our aggregation state, but the current code is too complex and
> > causing too many issues. We also need to think about this in the context
> > of multi-virtual-channel support.
> 
> Well crap.  Why don't you try to fix it right instead?

Can't even understand it, I have a better chance just rewriting it.

Like I said -- I know I'll have to do that, but I need to think about
this in the context of using different channels on different virtual
interfaces etc. and probably rework the channel config logic in mac80211
significantly...

johannes


  reply	other threads:[~2011-11-08 17:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 17:10 [RFT/FYI] mac80211: revert on-channel work optimisations Johannes Berg
2011-11-08 17:17 ` Ben Greear
2011-11-08 17:18   ` Johannes Berg [this message]
2011-11-08 17:25     ` Ben Greear
2011-11-08 17:56       ` Johannes Berg
2011-11-08 18:08         ` Ben Greear
2011-11-08 18:38           ` Johannes Berg
2011-11-25 11:27             ` Stanislaw Gruszka
2011-11-25 11:29               ` Johannes Berg
2012-02-17 15:44   ` Johannes Berg
2012-02-17 16:13     ` Ben Greear
2012-02-17 18:19       ` Johannes Berg
2012-02-17 18:38         ` Ben Greear
2012-02-18 17:39           ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320772727.24797.23.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).