From: Johannes Berg <johannes@sipsolutions.net>
To: Scott James Remnant <scott@netsplit.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Kay Sievers <kay.sievers@vrfy.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Sam Leffler <sleffler@chromium.org>,
keybuk@google.com, "Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: [PATCH] net/wireless: add COUNTRY to to regulatory device uevent
Date: Tue, 08 Nov 2011 23:15:00 +0100 [thread overview]
Message-ID: <1320790500.23056.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1299609930-14011-1-git-send-email-scott@netsplit.com>
On Tue, 2011-03-08 at 10:45 -0800, Scott James Remnant wrote:
> From: Scott James Remnant <keybuk@google.com>
>
> Regulatory devices issue change uevents to inform userspace of a need
> to call the crda tool; however these can often be sent before udevd is
> running, and were not previously included in the results of
> udevadm trigger (which requests a new change event using the /uevent
> attribute of the sysfs object).
>
> Add a uevent function to the device type which includes the COUNTRY
> information from the last request if it has yet to be processed, the
> case of multiple requests is already handled in the code by checking
> whether an unprocessed one is queued in the same manner and refusing
> to queue a new one.
>
> The existing udev rule continues to work as before.
Luis points out that it looks like this caused the crash I reported
earlier today -- in the module exit path we have a use-after-free of
last_request now.
johannes
next prev parent reply other threads:[~2011-11-08 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 18:45 [PATCH] net/wireless: add COUNTRY to to regulatory device uevent Scott James Remnant
2011-11-08 22:15 ` Johannes Berg [this message]
2011-11-08 22:31 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320790500.23056.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=keybuk@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=scott@netsplit.com \
--cc=sleffler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox