From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: "Matthew Garrett" <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>,
"Martin Večeřa" <ja@marvec.org>,
"Alejandro Vidal Mata" <alex14@gmail.com>,
"Javier Vidal Mata" <javitu@gmail.com>,
"Tino Schmidt" <mailtinoshomepage@gmx.net>,
631664@bugs.debian.org
Subject: Re: [PATCH] x86: Add amilo-rfkill driver for some Fujitsu-Siemens Amilo laptops
Date: Wed, 09 Nov 2011 09:30:58 +0100 [thread overview]
Message-ID: <1320827458.3845.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1320817459.18929.50.camel@deadeye> (sfid-20111109_064459_718264_1D22260D)
On Wed, 2011-11-09 at 05:44 +0000, Ben Hutchings wrote:
> +static bool init_blocked = false;
> +
> +/* Initial state set by 'radio' parameter, as in the fsaa1655g driver */
> +module_param_named(radio, init_blocked, invbool, 0);
I wonder what you need this for -- it shouldn't be necessary and the way
rfkill_init_sw_state() works might cause unexpected behaviour. I
recommend leaving that out, if you do leave it out rfkill will set the
desired state of the device as soon as the device is registered.
johannes
prev parent reply other threads:[~2011-11-09 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 5:44 [PATCH] x86: Add amilo-rfkill driver for some Fujitsu-Siemens Amilo laptops Ben Hutchings
2011-11-09 8:30 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320827458.3845.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=631664@bugs.debian.org \
--cc=alex14@gmail.com \
--cc=ben@decadent.org.uk \
--cc=ja@marvec.org \
--cc=javitu@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mailtinoshomepage@gmx.net \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).