From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Arik Nemtsov <arik@wizery.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: 3.2-rc1: system locks up upon inserting brcmsmac
Date: Wed, 09 Nov 2011 22:35:22 +0100 [thread overview]
Message-ID: <1320874522.3845.109.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4EBAF088.2040406@broadcom.com>
On Wed, 2011-11-09 at 22:28 +0100, Arend van Spriel wrote:
> Hi John,
>
> I merged wireless-testing master with our main development branch and
> got a hanging system. So I tested your master branch after that and the
> same result. Given the kernel log it may be the commit mentioned below
> although I did not bisect it yet.
>
> 077a91548 mac80211: support adding IV-room in the skb for CCMP keys
Yeah that commit looks like it would add the bug -- it should check
info->control.hw_key before the second test of
IEEE80211_KEY_FLAG_PUT_IV_SPACE in ccmp_encrypt_skb.
Try
- if (info->control.hw_key->flags & IEEE80211_KEY_FLAG_PUT_IV_SPACE)
+ if (info->control.hw_key && info->control.hw_key->flags & IEEE80211_KEY_FLAG_PUT_IV_SPACE)
johannes
next prev parent reply other threads:[~2011-11-09 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 21:28 3.2-rc1: system locks up upon inserting brcmsmac Arend van Spriel
2011-11-09 21:35 ` Johannes Berg [this message]
2011-11-09 21:50 ` Arend van Spriel
2011-11-09 22:31 ` Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320874522.3845.109.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=arik@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox