From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Arend van Spriel <arend@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] brcmsmac: Use current logging styles
Date: Sun, 13 Nov 2011 17:10:30 -0800 [thread overview]
Message-ID: <1321233030.15834.12.camel@Joe-Laptop> (raw)
In-Reply-To: <20111113170825.6633b17e@nehalam.linuxnetplumber.net>
On Sun, 2011-11-13 at 17:08 -0800, Stephen Hemminger wrote:
> On Sun, 13 Nov 2011 11:41:04 -0800
> Joe Perches <joe@perches.com> wrote:
>
> > Add and use pr_fmt and pr_<level>
> > Remove useless double parentheses from macros.
> > Remove function names from format strings, add to pr_debug use.
> > Coalesce formats.
> > Remove uncompileable undeclared variable in a DMA_NONE use.
>
> If you are going to change it why not got all the way to netdev_XXX and dev_XXX macros
> instead.
No dev always available, simpler change,
mirrors the changes in brcmfmac.
next prev parent reply other threads:[~2011-11-14 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 19:41 [PATCH] brcmsmac: Use current logging styles Joe Perches
2011-11-14 1:08 ` Stephen Hemminger
2011-11-14 1:10 ` Joe Perches [this message]
2011-11-14 10:13 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321233030.15834.12.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=arend@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).