From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v9 2/2] mac80211: Support ht-cap over-rides.
Date: Fri, 18 Nov 2011 18:35:21 +0100 [thread overview]
Message-ID: <1321637721.10266.72.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4EC69658.8000309@candelatech.com>
On Fri, 2011-11-18 at 09:31 -0800, Ben Greear wrote:
> >>> This looks like it has endian bugs. Note that sband->ht_cap is
> >>> ieee80211_sta_ht_cap, whereas sdata->u.mgd.ht_capa[_mask] is
> >>> ieee80211_ht_cap -- the latter is in IEEE format (LE) while the former
> >>> is in a complete different format that's easier to digest for the
> >>> CPU :-)
> >>
> >> So, the ht-caps& mask data coming from user-space via netlink
> >> should be in network-byte order?
> >
> > It is that way right now, and that makes sense.
>
> Ok, I think I am using host-byte-order currently in my iw
> and hostap patches, which is why everything works for me.
>
> But, I'll flip that all around....
You're using x86 so 802.11 byte order == CPU byte order...
Be careful: "network byte order" usually means big endian...
johannes
next prev parent reply other threads:[~2011-11-18 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 21:54 [PATCH v9 1/2] wireless: Support ht-capabilities over-rides greearb
2011-11-17 21:54 ` [PATCH v9 2/2] mac80211: Support ht-cap over-rides greearb
2011-11-18 10:15 ` Johannes Berg
2011-11-18 17:09 ` Ben Greear
2011-11-18 17:28 ` Johannes Berg
2011-11-18 17:31 ` Ben Greear
2011-11-18 17:35 ` Johannes Berg [this message]
2011-11-18 10:04 ` [PATCH v9 1/2] wireless: Support ht-capabilities over-rides Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2011-11-08 23:15 [PATCH v9 2/2] mac80211: Support ht-cap over-rides greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321637721.10266.72.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox