From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
"Luis R. Rodriguez" <lrodriguez@qca.qualcomm.com>
Subject: Re: [PATCH] compat-wireless: avoid pr_fmt build SPAM
Date: Fri, 18 Nov 2011 22:00:12 +0100 [thread overview]
Message-ID: <1321650012.10266.78.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1321649673-15874-1-git-send-email-linville@tuxdriver.com> (sfid-20111118_215835_740990_2277842B)
On Fri, 2011-11-18 at 15:54 -0500, John W. Linville wrote:
> The way the compat-* header files are included causes the default
> pr_fmt definition from <linux/kernel.h> to be evaluated for every file.
> Files that define pr_fmt then generate a lot of build SPAM about
> pr_fmt being redefined.
>
> Eliminate the build noise by preemptively undefining pr_fmt in those
> files that define it. This is accomplished by adding a patch to the
> patches directory.
This patch is going to be relatively painful when files move etc -- is
that really worth it? I for one will just drop it in our compat version
if it goes in since I don't even have all the files it patches :-)
johannes
next prev parent reply other threads:[~2011-11-18 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 20:54 [PATCH] compat-wireless: avoid pr_fmt build SPAM John W. Linville
2011-11-18 21:00 ` Johannes Berg [this message]
2011-11-18 21:09 ` John W. Linville
2011-11-18 21:12 ` Luis R. Rodriguez
2011-11-18 21:49 ` John W. Linville
2011-11-18 22:26 ` Joe Perches
2011-11-18 22:34 ` John W. Linville
2011-11-18 23:03 ` Luis R. Rodriguez
2011-11-18 23:21 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321650012.10266.78.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).