From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: mac80211: AP mode - question about Tx buffered unicast frames drop timeout
Date: Thu, 24 Nov 2011 14:03:46 +0100 [thread overview]
Message-ID: <1322139826.5366.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAFED-j=5-s7V9HZvYJDJ14KbVm+ioa=KnoBh1fj2ueT05QusTQ@mail.gmail.com> (sfid-20111123_193713_190763_C0FC3E1C)
On Wed, 2011-11-23 at 19:36 +0100, Janusz Dziedzic wrote:
> Hello,
>
> in sta_info.c I see function we call to remove expired unicast buffered frames.
>
> sta_info_buffer_expired()
> {
> ...
> timeout = (sta->listen_interval *
> sta->sdata->vif.bss_conf.beacon_int *
> 32 / 15625) * HZ;
> if (timeout < STA_TX_BUFFER_EXPIRE)
> timeout = STA_TX_BUFFER_EXPIRE;
> ...
> }
>
> STA_TX_BUFFER_EXPIRE is define as 10 seconds.
> Do you remember why we set this as 10 seconds in case we calculate lower value?
> This "listen_interval" calculation seems to be correct.
> I found this during UAPSD debuging in AP mode.
I have no idea. It's probably just really old code. Now -- why would you
sleep for longer than 10 seconds? That's pretty bad user experience :)
But really, I don't know, and I wouldn't mind changing it either I
think.
johannes
next prev parent reply other threads:[~2011-11-24 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 18:36 mac80211: AP mode - question about Tx buffered unicast frames drop timeout Janusz Dziedzic
2011-11-24 13:03 ` Johannes Berg [this message]
2011-11-24 21:28 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322139826.5366.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=janusz.dziedzic@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).