From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org,
Chun-Yeow Yeoh <yeohchunyeow@gmail.com>,
linville@tuxdriver.com
Subject: Re: [PATCH 1/7] {nl,cfg,mac}80211: Allow Setting Multicast Rate in Mesh
Date: Thu, 24 Nov 2011 16:15:16 +0100 [thread overview]
Message-ID: <1322147716.5366.22.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1322080347-7644-2-git-send-email-thomas@cozybit.com> (sfid-20111123_213313_268163_2293C7FE)
On Wed, 2011-11-23 at 12:32 -0800, Thomas Pedersen wrote:
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -5648,6 +5648,11 @@ static int nl80211_join_mesh(struct sk_buff *skb, struct genl_info *info)
> setup.mesh_id = nla_data(info->attrs[NL80211_ATTR_MESH_ID]);
> setup.mesh_id_len = nla_len(info->attrs[NL80211_ATTR_MESH_ID]);
>
> + if (info->attrs[NL80211_ATTR_MCAST_RATE] &&
> + !nl80211_parse_mcast_rate(rdev, setup.mcast_rate,
> + nla_get_u32(info->attrs[NL80211_ATTR_MCAST_RATE])))
> + return -EINVAL;
That could use some better indentation ...
johannes
next prev parent reply other threads:[~2011-11-24 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 20:32 [PATCH 0/7] mesh fixes and improvements Thomas Pedersen
2011-11-23 20:32 ` [PATCH 1/7] {nl,cfg,mac}80211: Allow Setting Multicast Rate in Mesh Thomas Pedersen
2011-11-24 15:15 ` Johannes Berg [this message]
2011-11-23 20:32 ` [PATCH 2/7] mac80211: failed forwarded mesh frame addressing Thomas Pedersen
2011-11-23 20:32 ` [PATCH 3/7] mac80211: fix switched HWMP frame addresses Thomas Pedersen
2011-11-23 20:32 ` [PATCH 4/7] mac80211: fix forwarded mesh frame queue mapping Thomas Pedersen
2011-11-24 15:16 ` Johannes Berg
2011-11-25 1:03 ` Thomas Pedersen
2011-11-23 20:32 ` [PATCH 5/7] {nl,cfg,mac}80211: implement dot11MeshHWMPperrMinInterval Thomas Pedersen
2011-11-23 20:32 ` [PATCH 6/7] mac80211: don't initiate path discovery when forwarding frame with unknown DA Thomas Pedersen
2011-11-23 20:32 ` [PATCH 7/7] mac80211: clean up rx_h_mesh_fwding Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322147716.5366.22.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).