Re: [PATCH v2 0/3] mac80211: timeout tx agg sessions in way similar to rx agg sessions

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2011-11-22 at 21:50 -0500, Nikolay Martynov wrote:
> Currently tx aggregation is not being timed out even if timeout is
> specified when aggregation is opened. Tx tid stays active until delba
> arrives from recipient (i.e. recipient times out tid when it is
> inactive).
>   The problem with this approach is that delba can get lost in the air
> and tx tid will stay perpetually opened on the originator while closed
> on recipient thus all data sent via this tid will be lost.
>  The problem manifests itself with connection becoming slow/unusable
> with ping times jumping to 4s. At such time opened tx tid can be seen
> on one side of the connection without corresponding rx tid one the
> other side. This seems to be happening quite often soon after
> connection on ar9102 I have.
>   This patch implements tx tid timeouting in way very similar to rx tid
> timeouting.
> 
>   All comments and suggestions are appreciated.

Looks OK to me. Did you run it through sparse too? :-)

johannes