From: Johannes Berg <johannes@sipsolutions.net>
To: Ivan Bezyazychnyy <ivan.bezyazychnyy@gmail.com>
Cc: linux-wireless@vger.kernel.org, Mike Krinkin <krinkin.m.u@gmail.com>
Subject: Re: [RFC v2 1/8] cfg80211 and nl80211: mesh power mode config parameter
Date: Thu, 24 Nov 2011 19:21:37 +0100 [thread overview]
Message-ID: <1322158897.5366.28.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1321886416-12597-2-git-send-email-ivan.bezyazychnyy@gmail.com> (sfid-20111121_154143_503349_E0664691)
On Mon, 2011-11-21 at 18:40 +0400, Ivan Bezyazychnyy wrote:
> According to IEEE80211s standard a mesh STA maintains a mesh power mode
> for non-peer mesh STAs. Non-peer mesh power mode is a mesh configuration
> parameter so it should be presented in mesh_config structure. Possible
> values for mesh power mode are presented in nl80211_mesh_power_mode
> enumeration. These modes are active, light sleep and deep sleep.
This patch seems a bit strange to me because it adds an nl80211 enum
without an attribute it can be carried in.
> @@ -765,6 +765,8 @@ struct mesh_config {
> u16 dot11MeshMaxPeerLinks;
> u8 dot11MeshMaxRetries;
> u8 dot11MeshTTL;
> + /* non-peer mesh power save mode */
> + u8 power_mode;
You're later using casts etc -- shouldn't this be the enum-typed
variable?
johannes
next prev parent reply other threads:[~2011-11-24 18:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 14:40 [RFC v2 0/8] mesh power saving implementation: indication Ivan Bezyazychnyy
2011-11-21 14:40 ` [RFC v2 1/8] cfg80211 and nl80211: mesh power mode config parameter Ivan Bezyazychnyy
2011-11-24 18:21 ` Johannes Berg [this message]
2011-11-21 14:40 ` [RFC v2 2/8] mac80211: mesh power mode indication in QoS frames Ivan Bezyazychnyy
2011-11-24 18:23 ` Johannes Berg
2011-11-21 14:40 ` [RFC v2 3/8] mac80211: tracking mesh peer link-specific power mode Ivan Bezyazychnyy
2011-11-24 18:26 ` Johannes Berg
2011-11-21 14:40 ` [RFC v2 4/8] mac80211: mesh non-peer power mode indication in beacons Ivan Bezyazychnyy
2011-11-21 14:40 ` [RFC v2 5/8] mac80211: setting link-specific mesh power modes when plink opens Ivan Bezyazychnyy
2011-11-24 18:29 ` Johannes Berg
2011-11-21 14:40 ` [RFC v2 6/8] cfg80211 and nl80211: Setting local link-specific power mode Ivan Bezyazychnyy
2011-11-21 14:40 ` [RFC v2 7/8] cfg80211 and nl80211: getting local and peer mesh power modes Ivan Bezyazychnyy
2011-11-24 18:31 ` Johannes Berg
2011-11-21 14:40 ` [RFC v2 8/8] cfg80211 and nl80211: setting and getting mesh non-peer power mode Ivan Bezyazychnyy
2011-11-24 18:33 ` [RFC v2 0/8] mesh power saving implementation: indication Johannes Berg
2011-11-25 18:35 ` Ivan Bezyazychnyy
2011-11-25 1:40 ` Javier Cardona
2011-11-25 18:40 ` Ivan Bezyazychnyy
-- strict thread matches above, loose matches on Subject: below --
2011-11-21 13:14 [RFC v2 1/8] cfg80211 and nl80211: mesh power mode config parameter Ivan Bezyazychnyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322158897.5366.28.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ivan.bezyazychnyy@gmail.com \
--cc=krinkin.m.u@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).