From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: Nikolay Martynov <mar.kolya@gmail.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Norbert Preining <preining@logic.at>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH v3] mac80211: fix race condition caused by late addBA response
Date: Mon, 28 Nov 2011 14:18:05 +0100 [thread overview]
Message-ID: <1322486285.4060.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CANUX_P1c_-JcinU5iWiS5tZo-vvE+RECzW6P13S+JOfFAyH4Ag@mail.gmail.com> (sfid-20111128_133506_902028_2F8CE6CE)
On Mon, 2011-11-28 at 14:34 +0200, Emmanuel Grumbach wrote:
> On Mon, Nov 28, 2011 at 10:16, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Mon, 2011-11-28 at 08:35 +0200, Emmanuel Grumbach wrote:
> >
> >> > /*
> >> > * addba_resp_timer may have fired before we got here, and
> >> > * caused WANT_STOP to be set. If the stop then was already
> >> > * processed further, STOPPING might be set.
> >> > */
> >> >
> >> >
> >> > Did you notice that I moved this code to after the dialog token check?
> >> >
> >>
> >> Don't you think we should also send a delBA ? The AP thinks we will Tx
> >> in Agg and basically we are now out of sync.
> >
> > We do, during the timer stop path, afaict.
> >
>
> Yes, but obviously the AP didn't hear it since it sent the addBA resp.
> IMHO, we should send it again.
I don't think so? This is addressing a race between the timer &
receiving the frame, so typically the delBA would not have gone out yet.
johannes
next prev parent reply other threads:[~2011-11-28 13:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 7:23 [PATCH] mac80211: fix race condition caused by late addBA resp Nikolay Martynov
2011-11-27 7:23 ` Nikolay Martynov
2011-11-27 9:38 ` Johannes Berg
2011-11-27 10:42 ` Emmanuel Grumbach
2011-11-27 15:43 ` Nikolay Martynov
2011-11-27 11:50 ` [PATCH v2] mac80211: fix race condition caused by late addBA response Johannes Berg
2011-11-27 11:53 ` [PATCH v3] " Johannes Berg
2011-11-27 16:12 ` Nikolay Martynov
2011-11-27 16:55 ` Johannes Berg
2011-11-28 6:35 ` Emmanuel Grumbach
2011-11-28 8:16 ` Johannes Berg
2011-11-28 12:34 ` Emmanuel Grumbach
2011-11-28 13:18 ` Johannes Berg [this message]
2011-11-28 14:21 ` Nikolay Martynov
2011-11-28 8:18 ` [PATCH v4] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322486285.4060.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mar.kolya@gmail.com \
--cc=preining@logic.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).