From: Johannes Berg <johannes@sipsolutions.net>
To: Nikolay Martynov <mar.kolya@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: reset addba retries after timeout
Date: Tue, 29 Nov 2011 16:19:33 +0100 [thread overview]
Message-ID: <1322579973.4110.22.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CALGY4fvLSKBY93M9Bhb-F8Sm=Uw5nU+OvTtAmk_BXQX8WX6V8A@mail.gmail.com> (sfid-20111129_161520_149493_69E914E7)
Hi Nikolay,
> > Conceptually, this seems OK to me, although on broken APs it might mean
> > connection stalls every minute, not sure how desirable that is?
>
> Do APs broken is such way exist? I.e. APs which declare aggregation
> support but do not respond to addba.
I seem to remember something ... not really sure.
> On the other hand looking at the code I've got an impression that
> connection doesn't stall while waiting for addba resp, i.e. packets
> still go though non-agg path. Did I miss something in this regards?
We queue up packets in ieee80211_tx_prep_agg() when
HT_AGG_STATE_WANT_START is clear but HT_AGG_STATE_OPERATIONAL is not
set, this is the case after we send the addBA request frame and before
we get a response. So since the timeout is 1 second, the connection can
stall for quite a while.
johannes
next prev parent reply other threads:[~2011-11-29 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 2:27 [PATCH] mac80211: reset addba retries after timeout Nikolay Martynov
2011-11-29 8:24 ` Johannes Berg
2011-11-29 15:14 ` Nikolay Martynov
2011-11-29 15:19 ` Johannes Berg [this message]
2011-11-29 22:01 ` Nikolay Martynov
2011-11-29 22:14 ` Johannes Berg
2011-11-29 22:28 ` Nikolay Martynov
2011-11-29 22:35 ` Johannes Berg
2011-11-29 22:46 ` Nikolay Martynov
2011-11-30 8:32 ` Johannes Berg
2011-11-30 14:16 ` Nikolay Martynov
2011-12-06 3:03 ` Nikolay Martynov
2011-12-06 9:09 ` Johannes Berg
2011-12-09 3:43 ` [PATCH v2] mac80211: split addba retries in time Nikolay Martynov
2011-12-09 8:02 ` Helmut Schaa
[not found] ` <CALGY4fvo7DMp+_+=wU+072v7sfA6EWfd_weM-G4B3ZxVYEaWhA@mail.gmail.com>
2011-12-12 18:53 ` Helmut Schaa
2011-12-13 20:25 ` John W. Linville
2011-12-18 0:39 ` [PATCH v3] " Nikolay Martynov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322579973.4110.22.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mar.kolya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).