Re: [PATCH] mac80211: reset addba retries after timeout

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2011-11-29 at 17:28 -0500, Nikolay Martynov wrote:
> Hi.
> 
> 2011/11/29 Johannes Berg <johannes@sipsolutions.net>:
> > On Tue, 2011-11-29 at 17:01 -0500, Nikolay Martynov wrote:
> >
> >> >>   Do APs broken is such way exist? I.e. APs which declare aggregation
> >> >> support but do not respond to addba.
> >> >
> >> > I seem to remember something ... not really sure.
> >>
> >>   If such APs exist I think it might be possible to extend my patch to
> >> do something like the following. For the first time make 10 attempts
> >> to establish addba. If this fails - make no more attempts for the
> >> duration of the connection. If this succeeds - use logic I've added in
> >> the patch. This should handle broken APs and won't allow agg to be
> >> disable because of some random blackout.
> >
> > Wouldn't that be equivalent to just bumping the number of tries?
> 
>   Well, sort of if you are willing to bump it to 10-15, I guess it
> would be kind of same thing.
>   I've seen couple of times when 3 wasn't enough and agg got disabled,
> but 10-15 seems reasonably large to give up completely.

Maybe the better approach would be to bump it up, but also only allow an
attempt once every say 15 seconds or so? It seems kinda useless to try 3
(or 10/15) times in quick succession and then give up, vs. just trying
more spaced out?

johannes