linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Martynov <mar.kolya@gmail.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, Nikolay Martynov <mar.kolya@gmail.com>
Subject: [PATCH v3 0/4] Fix the way ANI is being handled for ar9100 and ar9340
Date: Wed, 30 Nov 2011 15:46:16 -0500	[thread overview]
Message-ID: <1322685980-8757-1-git-send-email-mar.kolya@gmail.com> (raw)
In-Reply-To: <20111130201051.GC2477@tuxdriver.com>

  I'm really sorry that I missed all those tabs-vs-spaces. Please accept my apologies.
  I think I've now fixed all problems and checkpatch.pl doesn't report
any issues. Please let me know if there are still style problems.
  Thanks!

  Currently in ath9k code there is an attempt which is meant to
disable ANI for ar9100 and ar9340. But it doesn't really achieve
this. All it does is disable ANI init and setup (i.e. calls to
ath9k_hw_ani_setup and ath9k_hw_ani_init). Since ath9k_hw_ani_setup is
not called ah->config.ani_poll_interval is never initialized (i.e. it
is always zero) and ath_ani_calibrate always executes ANI procedures
(over uninitialized ANI parameters).
  Moreover, ath_ani_calibrate is being called each 1ms because
common->ani.timer is set to zero interval because
ah->config.ani_poll_interval==0 (and thus smallest value of all
intervals). Normally it should not be called this often.
  This patch changes the code so config.enable_ani is used to check if
ANI should be performed.
  Also, this patchset enables ANI for ar9100 - ANI was always performed
for this chip, but this patch fixes the fact that it was performed
over uninitialized data.

  All comments and suggestions are appreciated.
  Thanks.

Nikolay Martynov (4):
  ath9k: trivial: cosmetic fix in calibration debug log
  ath9k: change calibration debug log to output all calibration types
  ath9k: use config.enable_ani to check if ani should be performed
  ath9k: enable ANI for ar9100 chips

 drivers/net/wireless/ath/ath9k/ar9002_calib.c |    2 +-
 drivers/net/wireless/ath/ath9k/ar9003_calib.c |    2 +-
 drivers/net/wireless/ath/ath9k/htc_drv_main.c |    3 ++-
 drivers/net/wireless/ath/ath9k/hw.c           |    6 +++++-
 drivers/net/wireless/ath/ath9k/main.c         |   13 ++++++++-----
 5 files changed, 17 insertions(+), 9 deletions(-)

-- 
1.7.4.1


  reply	other threads:[~2011-11-30 20:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28  0:22 [PATCH v2 0/4] Fix the way ANI is being handled for ar9100 and ar9340 Nikolay Martynov
2011-11-28  0:22 ` [PATCH v2 1/4] ath9k: trivial: cosmetic fix in calibration debug log Nikolay Martynov
2011-11-28  2:52   ` Julian Calaby
2011-11-28  3:49     ` Nikolay Martynov
2011-11-28  3:51     ` [PATCH v3] " Nikolay Martynov
2011-11-28  0:22 ` [PATCH v2 2/4] ath9k: change calibration debug log to output all calibration types Nikolay Martynov
2011-11-28  0:22 ` [PATCH v2 3/4] ath9k: use config.enable_ani to check if ani should be performed Nikolay Martynov
2011-11-28  0:22 ` [PATCH v2 4/4] ath9k: enable ANI for ar9100 chips Nikolay Martynov
2011-11-28  1:09 ` [PATCH v2 0/4] Fix the way ANI is being handled for ar9100 and ar9340 Adrian Chadd
2011-11-28  1:18   ` Adrian Chadd
2011-11-28  2:35     ` Nikolay Martynov
2011-11-30 20:10 ` John W. Linville
2011-11-30 20:46   ` Nikolay Martynov [this message]
2011-11-30 20:46     ` [PATCH v3 1/4] ath9k: trivial: cosmetic fix in calibration debug log Nikolay Martynov
2011-11-30 20:46     ` [PATCH v3 2/4] ath9k: change calibration debug log to output all calibration types Nikolay Martynov
2011-11-30 20:46     ` [PATCH v3 3/4] ath9k: use config.enable_ani to check if ani should be performed Nikolay Martynov
2011-12-02 11:04       ` Felix Fietkau
2011-12-02 15:22         ` Nikolay Martynov
2011-12-02 16:40           ` Felix Fietkau
2011-11-30 20:46     ` [PATCH v3 4/4] ath9k: enable ANI for ar9100 chips Nikolay Martynov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322685980-8757-1-git-send-email-mar.kolya@gmail.com \
    --to=mar.kolya@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).