From: Johannes Berg <johannes@sipsolutions.net>
To: wwguy <wey-yi.w.guy@intel.com>
Cc: Nikolay Martynov <mar.kolya@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: iwlwifi: kernel panic if try to open tid with large index (>=8)
Date: Fri, 02 Dec 2011 21:19:29 +0100 [thread overview]
Message-ID: <1322857169.4124.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1322838068.24199.0.camel@wwguy-ubuntu>
On Fri, 2011-12-02 at 07:01 -0800, wwguy wrote:
> On Fri, 2011-12-02 at 01:11 -0800, Johannes Berg wrote:
> > On Thu, 2011-12-01 at 23:29 -0500, Nikolay Martynov wrote:
> > > Hi.
> > >
> > > I have an intel 5300 card running on latest compat-wireless.
> > > If I do:
> > > echo "tx start 8" >
> > > /sys/kernel/debug/ieee80211/phy0/netdev\:wlan1/stations/XX\:XX\:XX\:XX\:XX\:XX/agg_status
> >
> > Yikes. I think mac80211 should just reject that since it will never put
> > traffic into that TID anyway.
> >
> Johannes, are you going to help fix that :-)
I *think* this is the right fix. Do you agree? It fixes it for sure --
but does it really not have any side effects? I'm pretty sure it doesn't
since I looked at all the code just now ...
johannes
---
drivers/net/wireless/iwlwifi/iwl-commands.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/wireless/iwlwifi/iwl-commands.h 2011-12-02 21:12:01.000000000 +0100
+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h 2011-12-02 21:12:02.000000000 +0100
@@ -814,7 +814,7 @@ struct iwl_qosparam_cmd {
#define IWLAGN_STATION_COUNT 16
#define IWL_INVALID_STATION 255
-#define IWL_MAX_TID_COUNT 9
+#define IWL_MAX_TID_COUNT 8
#define STA_FLG_TX_RATE_MSK cpu_to_le32(1 << 2)
#define STA_FLG_PWR_SAVE_MSK cpu_to_le32(1 << 8)
next prev parent reply other threads:[~2011-12-02 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 4:29 iwlwifi: kernel panic if try to open tid with large index (>=8) Nikolay Martynov
2011-12-02 3:42 ` Guy, Wey-Yi
2011-12-02 9:11 ` Johannes Berg
2011-12-02 15:01 ` wwguy
2011-12-02 20:19 ` Johannes Berg [this message]
2011-12-02 20:14 ` wwguy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322857169.4124.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mar.kolya@gmail.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox