From: Johannes Berg <johannes@sipsolutions.net>
To: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, "Hsu,
Kenny" <kenny.hsu@intel.com>
Subject: Re: [PATCH 07/15] iwlwifi: add device ID information support by testmode
Date: Sat, 10 Dec 2011 18:51:19 +0100 [thread overview]
Message-ID: <1323539479.3344.31.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1323390382-1678-8-git-send-email-wey-yi.w.guy@intel.com> (sfid-20111209_022535_454507_1587E816)
On Thu, 2011-12-08 at 16:26 -0800, Wey-Yi Guy wrote:
> + case IWL_TM_CMD_APP2DEV_GET_DEVICE_ID:
> + bus_get_hw_id(bus(priv), buf, sizeof(buf));
> + ptr = buf;
> + strsep(&ptr, ":");
> + sscanf(strsep(&ptr, ":"), "%x", &num);
> + sscanf(strsep(&ptr, ":"), "%x", &devid);
This is kinda ugly too ... sorry, should've seen it earlier.
johannes
next prev parent reply other threads:[~2011-12-10 17:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 0:26 [PATCH 0/15] update for 3.3: iwlwifi 2011-12-08 Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 01/15] iwlwifi: add uCode version information support by testmode Wey-Yi Guy
2011-12-10 16:10 ` Kalle Valo
2011-12-10 16:25 ` Guy, Wey-Yi
2011-12-12 11:45 ` Kalle Valo
2011-12-12 19:48 ` Guy, Wey-Yi
2011-12-09 0:26 ` [PATCH 02/15] iwlwifi: hide kernel option IWLWIFI_DEVICE_SVTOOL Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 03/15] iwlwifi: Display more uCode debug info Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 04/15] iwlwifi: minor cleanup Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 05/15] iwlwifi: remove reference to legacy devices Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 06/15] iwlwifi: rename CONFIG_IWLWIFI_DEVICE_SVTOOL to CONFIG_IWLWIFI_DEVICE_TESTMODE Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 07/15] iwlwifi: add device ID information support by testmode Wey-Yi Guy
2011-12-10 16:15 ` Kalle Valo
2011-12-10 17:31 ` wwguy
2011-12-10 17:51 ` Johannes Berg [this message]
2011-12-10 17:51 ` wwguy
2011-12-09 0:26 ` [PATCH 08/15] iwlwifi: P2P is not enabled by default Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 09/15] iwlwifi: set TX_CMD_FLG_STA_RATE_MSK for BAR frame Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 10/15] iwlwifi: move eeprom pointer from iwl_priv to iwl_shared Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 11/15] iwlwifi: move device_pointers " Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 12/15] iwlwifi: move calib_results list from iwl_priv to iwl_trans Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 13/15] iwlagn: fix TID use bug Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 14/15] iwlagn: use IWL_MAX_TID_COUNT for WoWLAN Wey-Yi Guy
2011-12-09 0:26 ` [PATCH 15/15] iwlagn: use IWL_MAX_TID_COUNT instead of TID_MAX_LOAD_COUNT Wey-Yi Guy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323539479.3344.31.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kenny.hsu@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).