Re: [PATCH 01/15] iwlwifi: add uCode version information support by testmode

["Guy, Wey-Yi" <wey-yi.w.guy@intel.com>]

On Mon, 2011-12-12 at 03:45 -0800, Kalle Valo wrote:
> "Guy, Wey-Yi" <wey-yi.w.guy@intel.com> writes:
> 
> > On Sat, 2011-12-10 at 08:10 -0800, Kalle Valo wrote:
> >> Wey-Yi Guy <wey-yi.w.guy@intel.com> writes:
> >> 
> >> > From: Hsu, Kenny <kenny.hsu@intel.com>
> >> >
> >> > Create new tm command to report uCode version to userspace
> >> > - IWL_TM_CMD_APP2DEV_GET_FW_VERSION
> >> 
> >> Why not use wiphy.fw_version which is specifally meant for this purpose?
> >> 
> >
> > fw_version is being formatted to string. we need u32
> 
> If the u32 format is so important (and I suspect it isn't, most likely
> you have string format for your version numbers as well) you can always
> format the u32 to hex, for example "0xdeadbeef".
> 
> Sure, it's ugly but still less ugly than having a private interface in
> the driver. The idea of nl80211 testmode is NOT to replicate wext
> private interface.
> 
it is ugly :-)
We are not try to replicate wext private interface, but just try to
support the need for our existing debugging applications.

Doing so will mean change the existing OS agnostic applications to
understand "string" format. 

Thanks
Wey