linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
	Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
	Kalle Valo <kvalo@qca.qualcomm.com>,
	Vivek Natarajan <nataraja@qualcomm.com>
Subject: Re: [RFC 2/2] mac80211: Fix power save in change save
Date: Tue, 13 Dec 2011 09:57:23 +0100	[thread overview]
Message-ID: <1323766643.3355.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1323766515-19223-2-git-send-email-mohammed@qca.qualcomm.com>

On Tue, 2011-12-13 at 14:25 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
> 
> we found that power save is not getting enabled when we do
> change interface in this order STA->IBSS->STA. this is
> because ieee80211_setup_sdata clears type-dependen union
> 
> Reported-by: Leela Kella <leela@qca.qualcomm.com>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
> ---
>  net/mac80211/mlme.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 67a6be1..d87fde3 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -2371,6 +2371,7 @@ void ieee80211_sta_setup_sdata(struct ieee80211_sub_if_data *sdata)
>  		    (unsigned long) sdata);
>  
>  	ifmgd->flags = 0;
> +	ifmgd->powersave = sdata->wdev.ps;

Makes sense.

johannes


  reply	other threads:[~2011-12-13  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13  8:55 [RFC 1/2] mac80211: remove an unnecessary paraenthesis Mohammed Shafi Shajakhan
2011-12-13  8:55 ` [RFC 2/2] mac80211: Fix power save in change save Mohammed Shafi Shajakhan
2011-12-13  8:57   ` Johannes Berg [this message]
2011-12-13  9:05     ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323766643.3355.2.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mohammed@qca.qualcomm.com \
    --cc=nataraja@qualcomm.com \
    --cc=vthiagar@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).