From: "John W. Linville" <linville@tuxdriver.com>
To: linux-wireless@vger.kernel.org
Cc: zajec5@gmail.com, "John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH] b43: avoid calling bcma_* if CONFIG_B43_BCMA is not set
Date: Wed, 14 Dec 2011 09:08:28 -0500 [thread overview]
Message-ID: <1323871708-19852-1-git-send-email-linville@tuxdriver.com> (raw)
Avoids this:
ERROR: "bcma_chipco_pll_write" [drivers/net/wireless/b43/b43.ko] undefined!
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
It looks like phy_lcn.c could use some bits like this as well...
drivers/net/wireless/b43/phy_n.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
index 6b95fd2..154f97d 100644
--- a/drivers/net/wireless/b43/phy_n.c
+++ b/drivers/net/wireless/b43/phy_n.c
@@ -4048,6 +4048,7 @@ int b43_phy_initn(struct b43_wldev *dev)
/* http://bcm-v4.sipsolutions.net/802.11/PmuSpurAvoid */
static void b43_nphy_pmu_spur_avoid(struct b43_wldev *dev, bool avoid)
{
+#ifdef CONFIG_B43_BCMA
struct bcma_drv_cc *cc = &dev->dev->bdev->bus->drv_cc;
u32 pmu_ctl;
if (dev->dev->chip_id == 43224 || dev->dev->chip_id == 43225) {
@@ -4098,6 +4099,9 @@ static void b43_nphy_pmu_spur_avoid(struct b43_wldev *dev, bool avoid)
return;
}
bcma_cc_set32(cc, BCMA_CC_PMU_CTL, pmu_ctl);
+#else
+ return;
+#endif
}
/* http://bcm-v4.sipsolutions.net/802.11/PHY/N/ChanspecSetup */
--
1.7.4.4
next reply other threads:[~2011-12-14 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 14:08 John W. Linville [this message]
2011-12-15 6:03 ` [PATCH] b43: avoid calling bcma_* if CONFIG_B43_BCMA is not set Rafał Miłecki
2011-12-15 6:06 ` Rafał Miłecki
2011-12-15 11:45 ` Rafał Miłecki
2011-12-16 21:33 ` John W. Linville
2011-12-16 23:32 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323871708-19852-1-git-send-email-linville@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox