From: Johannes Berg <johannes@sipsolutions.net>
To: Yogesh Ashok Powar <yogeshp@marvell.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Nishant Sarmukadam <nishants@marvell.com>
Subject: Re: [PATCH v2] mac80211: Purge A-MPDU TX queues before station destructions
Date: Wed, 14 Dec 2011 23:17:17 +0100 [thread overview]
Message-ID: <1323901037.3599.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20111208092608.GA4981@hertz.marvell.com>
On Thu, 2011-12-08 at 14:56 +0530, Yogesh Ashok Powar wrote:
> + /* There could be some memory leaks because of ampdu tx pending queue
> + * not being freed before destroying the station info.
> + *
> + * Make sure that such queues are purged before freeing the station
> + * info.
> + * TODO: We have to somehow postpone the full destruction
> + * until the aggregation stop completes. Refer
> + * http://thread.gmane.org/gmane.linux.kernel.wireless.general/81936
> + */
> + for (i = 0; i < STA_TID_NUM; i++) {
> + if (!sta->ampdu_mlme.tid_tx[i])
> + continue;
> + tid_tx = sta->ampdu_mlme.tid_tx[i];
Please address the sparse warning this creates with
CONFIG_SPARSE_RCU_POINTER=y
johannes
prev parent reply other threads:[~2011-12-14 22:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 9:26 [PATCH v2] mac80211: Purge A-MPDU TX queues before station destructions Yogesh Ashok Powar
2011-12-08 9:30 ` Johannes Berg
2011-12-14 22:17 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323901037.3599.6.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nishants@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox