From: Luciano Coelho <coelho@ti.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Pontus Fuchs <pontus.fuchs@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: Restore testmode ABI
Date: Thu, 15 Dec 2011 09:37:27 +0200 [thread overview]
Message-ID: <1323934647.2800.176.camel@cumari> (raw)
In-Reply-To: <87y5uwfsce.fsf@purkki.adurom.net>
Hi Kalle,
On Thu, 2011-12-01 at 13:23 +0200, Kalle Valo wrote:
> Pontus Fuchs <pontus.fuchs@gmail.com> writes:
>
> > Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
> > the ABI for testmode commands. Restore the ABI again.
> >
>
> [...]
>
> > --- a/drivers/net/wireless/wl12xx/testmode.c
> > +++ b/drivers/net/wireless/wl12xx/testmode.c
> > @@ -37,6 +37,7 @@ enum wl1271_tm_commands {
> > WL1271_TM_CMD_TEST,
> > WL1271_TM_CMD_INTERROGATE,
> > WL1271_TM_CMD_CONFIGURE,
> > + WL1271_TM_CMD_NVS_PUSH, /* Not in use. Keep to not break ABI */
>
> Better to call it WL1271_TM_CMD_UNUSED1, or something like that, so that
> it really stays unused.
As we discussed briefly on IRC, I think it's a better idea to keep it as
is. If anyone still uses it (despite the comment saying it's not in
use), we will return -EOPNOTSUPP.
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-12-15 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 11:13 [PATCH] wl12xx: Restore testmode ABI Pontus Fuchs
2011-12-01 11:23 ` Kalle Valo
2011-12-15 7:37 ` Luciano Coelho [this message]
2011-12-15 8:53 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323934647.2800.176.camel@cumari \
--to=coelho@ti.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pontus.fuchs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox