From: Luciano Coelho <coelho@ti.com>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: don't write out of bounds when hlid > WL12XX_MAX_LINKS
Date: Thu, 15 Dec 2011 10:53:39 +0200 [thread overview]
Message-ID: <1323939219.2800.178.camel@cumari> (raw)
In-Reply-To: <1323769142-20515-1-git-send-email-coelho@ti.com>
On Tue, 2011-12-13 at 11:39 +0200, Luciano Coelho wrote:
> We should not get an hlid value bigger than WL12XX_MAX_LINKS from
> wl1271_rx_handle_data(). We have a WARN_ON in case it happens. But
> despite the warning, we would still go ahead and write the hlid bit
> into active_hlids (a stack variable). This would cause us to
> overwrite other data in the stack.
>
> To avoid this problem, we now skip the write when issuing the warning,
> so at least we don't corrupt data.
>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> ---
Applied.
--
Cheers,
Luca.
prev parent reply other threads:[~2011-12-15 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 9:39 [PATCH] wl12xx: don't write out of bounds when hlid > WL12XX_MAX_LINKS Luciano Coelho
2011-12-15 8:53 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323939219.2800.178.camel@cumari \
--to=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox