Re: [PATCH] atheros: force endian checks on atheros wireless drivers

Luciano Coelho
2011-12-21T11:10:44Z

On Tue, 2011-12-20 at 11:18 -0800, Luis R. Rodriguez wrote:
> From: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
>
> Please NACK nasty patches.
>
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/Makefile b/drivers/net/wireless/ath/Makefile
> index d121469..d716b74 100644
> --- a/drivers/net/wireless/ath/Makefile
> +++ b/drivers/net/wireless/ath/Makefile
> @@ -11,3 +11,4 @@ ath-objs := main.o \
> key.o
>
> ath-$(CONFIG_ATH_DEBUG) += debug.o
> +ccflags-y += -D__CHECK_ENDIAN__

Doesn't this force everyone who compiles the modules (even
non-developers) to have sparse installed? Is it really what we want?

If that's the case, shouldn't we do this in a higher level, maybe
enforce sparse check for everything? Of course the number of warnings
would explode, but we could at least do it for all the wireless code in
a first phase?

--
Cheers,
Luca.