linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wl12xx: fix sched scan of DFS channels
@ 2011-12-20 10:04 Eyal Shapira
  2011-12-20 20:51 ` Luciano Coelho
  0 siblings, 1 reply; 2+ messages in thread
From: Eyal Shapira @ 2011-12-20 10:04 UTC (permalink / raw)
  To: Luciano Coelho; +Cc: linux-wireless

DFS channels weren't scanned properly because
min/max_duration weren't set for these channels
even though they're required by the FW.
The change sets passive_duration and min/max_duration
for all channels as the FW uses the correct parameters
according to the channel type.

Signed-off-by: Eyal Shapira <eyal@wizery.com>
---
 drivers/net/wireless/wl12xx/scan.c |   15 ++++++++-------
 1 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/scan.c b/drivers/net/wireless/wl12xx/scan.c
index 8599dab..260986b 100644
--- a/drivers/net/wireless/wl12xx/scan.c
+++ b/drivers/net/wireless/wl12xx/scan.c
@@ -437,18 +437,19 @@ wl1271_scan_get_sched_scan_channels(struct wl1271 *wl,
 
 			if (flags & IEEE80211_CHAN_RADAR) {
 				channels[j].flags |= SCAN_CHANNEL_FLAGS_DFS;
+
 				channels[j].passive_duration =
 					cpu_to_le16(c->dwell_time_dfs);
-			}
-			else if (flags & IEEE80211_CHAN_PASSIVE_SCAN) {
+			} else {
 				channels[j].passive_duration =
 					cpu_to_le16(c->dwell_time_passive);
-			} else {
-				channels[j].min_duration =
-					cpu_to_le16(c->min_dwell_time_active);
-				channels[j].max_duration =
-					cpu_to_le16(c->max_dwell_time_active);
 			}
+
+			channels[j].min_duration =
+				cpu_to_le16(c->min_dwell_time_active);
+			channels[j].max_duration =
+				cpu_to_le16(c->max_dwell_time_active);
+
 			channels[j].tx_power_att = req->channels[i]->max_power;
 			channels[j].channel = req->channels[i]->hw_value;
 
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] wl12xx: fix sched scan of DFS channels
  2011-12-20 10:04 [PATCH] wl12xx: fix sched scan of DFS channels Eyal Shapira
@ 2011-12-20 20:51 ` Luciano Coelho
  0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2011-12-20 20:51 UTC (permalink / raw)
  To: Eyal Shapira; +Cc: linux-wireless

On Tue, 2011-12-20 at 12:04 +0200, Eyal Shapira wrote: 
> DFS channels weren't scanned properly because
> min/max_duration weren't set for these channels
> even though they're required by the FW.
> The change sets passive_duration and min/max_duration
> for all channels as the FW uses the correct parameters
> according to the channel type.
> 
> Signed-off-by: Eyal Shapira <eyal@wizery.com>
> ---

Applied, thanks Eyal!

-- 
Cheers,
Luca.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-12-20 20:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-20 10:04 [PATCH] wl12xx: fix sched scan of DFS channels Eyal Shapira
2011-12-20 20:51 ` Luciano Coelho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).