Re: [PATCH 0/6] atheros-wireless: fix sparse warnings ho ho ho

Larry Finger
2011-12-20T19:01:40Z

On 12/20/2011 12:46 PM, Luis R. Rodriguez wrote:
> From: Luis R. Rodriguez<mcgrof@qca.qualcomm.com>
>
> Here's a slew of sparse warning fixes for all Atheros wireless drivers.
> These have been itching me for a while now. I ask all patch submitters
> and driver maintainers to please run their patches with these two tests:
>
> make C=1 M=drivers/net/wireless/ath/
>
> And then if all is happy try:
>
> make C=2 CF="-D__CHECK_ENDIAN__" M=drivers/net/wireless/ath/

Why not follow a suggestion that Johannes made to me? Add the line

ccflags-y += -D__CHECK_ENDIAN__

To the bottom of the make file(s). That way they only need one run. Then enforce
the rule by not ACKing any patches with too many of the endian warnings, and do
not allow any of the others.

Larry