Re: [PATCH 2/6] compat-wireless: remove platform_device_id for kernel < 2.6.30

Luciano Coelho
2011-12-23T08:58:20Z

On Thu, 2011-12-22 at 21:47 +0100, Hauke Mehrtens wrote:
> Kernel < 2.6.30 do not support struct platform_device_id, so remove it
> for them and hope that the probing will reject an invalid device.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---

This is not going to work. The only way the wl12xx module gets probed
is when a "wl12xx" platform device is added to the system. The
wl12xx_sdio or wl12xx_spi module instantiates a platform device with
"wl12xx" as the name, which causes the wl12xx module to be probed.

I don't know how modules handling platform devices were probed pre-.30.
Does anyone know?

Anything before 2.6.30 is *ancient*, and anyway, even before this change
we already needed changes in the "outer" kernel to get wl12xx to work.

The question is, should we even bother compiling wl12xx if the kernel is
< .30?

I'll update our wikipage to say athat starting from compat-wireless 3.2,
additional changes are required for < 2.6.30.

--
Cheers,
Luca.