From: Samuel Ortiz <samuel@sortiz.org>
To: ilanelias78@gmail.com
Cc: aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Ilan Elias <ilane@ti.com>
Subject: Re: [PATCH] NFC: Export new attributes sensb_res and sensf_res
Date: Mon, 16 Jan 2012 19:02:53 +0100 [thread overview]
Message-ID: <1326736973.22824.9.camel@sortiz-mobl> (raw)
In-Reply-To: <1326012961-29832-1-git-send-email-ilane@ti.com>
Hi Ilan,
On Sun, 2012-01-08 at 10:56 +0200, ilanelias78@gmail.com wrote:
> diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h
> index 8696b77..d8aef2e 100644
> --- a/include/net/nfc/nfc.h
> +++ b/include/net/nfc/nfc.h
> @@ -66,6 +66,8 @@ struct nfc_ops {
> #define NFC_TARGET_IDX_ANY -1
> #define NFC_MAX_GT_LEN 48
> #define NFC_MAX_NFCID1_LEN 10
> +#define NFC_MAX_SENSB_RES_LEN 12
> +#define NFC_MAX_SENSF_RES_LEN 18
I think those values should be exported to user space though
include/linux/nfc.h.
When fetching the byte stream from the netlink socket, you usually want
to check if it has a valid length in order to memcpy it to a static
array embedded with your target structure.
Same applies to NFC_MAX_NFCID1_LEN.
The rest of the code looks fine to me.
Cheers,
Samuel.
next prev parent reply other threads:[~2012-01-16 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 8:56 [PATCH] NFC: Export new attributes sensb_res and sensf_res ilanelias78
2012-01-16 18:02 ` Samuel Ortiz [this message]
2012-01-17 8:31 ` Elias, Ilan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326736973.22824.9.camel@sortiz-mobl \
--to=samuel@sortiz.org \
--cc=aloisio.almeida@openbossa.org \
--cc=ilane@ti.com \
--cc=ilanelias78@gmail.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox