[PATCH] NFC: Increase NCI deactivate timeout

[PATCH] NFC: Increase NCI deactivate timeout

[ilanelias78]

From: Ilan Elias <ilane@ti.com>

Increase NCI deactivate timeout from 5 sec to 30 sec.
NCI deactivate procedure might take a long time,
depending on the local and remote parameters.

Signed-off-by: Ilan Elias <ilane@ti.com>
---
 include/net/nfc/nci_core.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/nfc/nci_core.h b/include/net/nfc/nci_core.h
index bccd89e..f4963ea 100644
--- a/include/net/nfc/nci_core.h
+++ b/include/net/nfc/nci_core.h
@@ -47,7 +47,7 @@ enum {
 #define NCI_RESET_TIMEOUT			5000
 #define NCI_INIT_TIMEOUT			5000
 #define NCI_RF_DISC_TIMEOUT			5000
-#define NCI_RF_DEACTIVATE_TIMEOUT		5000
+#define NCI_RF_DEACTIVATE_TIMEOUT		30000
 #define NCI_CMD_TIMEOUT				5000
 
 struct nci_dev;
-- 
1.7.0.4

Re: [PATCH] NFC: Increase NCI deactivate timeout

[Samuel Ortiz]

Hi Ilan,

On Sun, 2012-01-08 at 13:43 +0200, ilanelias78@gmail.com wrote:
> From: Ilan Elias <ilane@ti.com>
> 
> Increase NCI deactivate timeout from 5 sec to 30 sec.
> NCI deactivate procedure might take a long time,
> depending on the local and remote parameters.
30 seconds sounds like a huge delay for receiving a reply to such command.
Would you care explaining how we can get that long of a timeout ?

Cheers,
Samuel.

RE: [PATCH] NFC: Increase NCI deactivate timeout

[Elias, Ilan]

 Hi Samuel,

> > Increase NCI deactivate timeout from 5 sec to 30 sec.
> > NCI deactivate procedure might take a long time,
> > depending on the local and remote parameters.
> 30 seconds sounds like a huge delay for receiving a reply to 
> such command.
> Would you care explaining how we can get that long of a timeout ?
The controller in the Reader side uses a value called nRETRY (see NFC Forum Digital spec).
This value is an internal implementation, valid range is 2 to 5.
This value determines the number of re-transmissions.

The controller in the Tag side uses a value called FWI - Frame Waiting time Integer (see NFC Forum Digital spec).
This value is an internal implementation, valid range is 1 to 14.
This value determines (via some formula) the FWT - Frame Waiting Time, which is a timout.
Max FWT value can be almost 5sec.

So, the total max timeout can be 5sec for the first packet + 5sec for each of the 5 re-transmissions = 5 + 5x5 = 30 sec.

> Cheers,
> Samuel.

Thanks & BR,
Ilan

Re: [PATCH] NFC: Increase NCI deactivate timeout

[Samuel Ortiz]

Hi Ilan,

On Sun, 2012-01-08 at 13:43 +0200, ilanelias78@gmail.com wrote:
> From: Ilan Elias <ilane@ti.com>
> 
> Increase NCI deactivate timeout from 5 sec to 30 sec.
> NCI deactivate procedure might take a long time,
> depending on the local and remote parameters.
> 
> Signed-off-by: Ilan Elias <ilane@ti.com>
Thanks for the explanations:

Acked-by: Samuel Ortiz <sameo@linux.intel.com>

Cheers,
Samuel.