From: Samuel Ortiz <samuel@sortiz.org>
To: ilanelias78@gmail.com
Cc: aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Ilan Elias <ilane@ti.com>
Subject: Re: [PATCH] NFC: Add NCI data exchange timer
Date: Mon, 16 Jan 2012 21:37:32 +0100 [thread overview]
Message-ID: <1326746252.22824.15.camel@sortiz-mobl> (raw)
In-Reply-To: <1326024683-30313-1-git-send-email-ilane@ti.com>
Hi Ilan,
A couple of nitpicks:
On Sun, 2012-01-08 at 14:11 +0200, ilanelias78@gmail.com wrote:
> @@ -454,8 +464,10 @@ static int nci_data_exchange(struct nfc_dev *nfc_dev, __u32 target_idx,
> return -EINVAL;
> }
>
> - if (test_and_set_bit(NCI_DATA_EXCHANGE, &ndev->flags))
> + if (test_and_set_bit(NCI_DATA_EXCHANGE, &ndev->flags)) {
> + pr_err("unable to exchange data, already in progress\n");
This is not really related to that patch.
> @@ -473,6 +485,8 @@ static struct nfc_ops nci_nfc_ops = {
> .dev_down = nci_dev_down,
> .start_poll = nci_start_poll,
> .stop_poll = nci_stop_poll,
> + .dep_link_up = NULL,
> + .dep_link_down = NULL,
Ditto.
Cheers,
Samuel.
next prev parent reply other threads:[~2012-01-16 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 12:11 [PATCH] NFC: Add NCI data exchange timer ilanelias78
2012-01-16 20:37 ` Samuel Ortiz [this message]
2012-01-17 9:48 ` Elias, Ilan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326746252.22824.15.camel@sortiz-mobl \
--to=samuel@sortiz.org \
--cc=aloisio.almeida@openbossa.org \
--cc=ilane@ti.com \
--cc=ilanelias78@gmail.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox