* [PATCH] NFC: Increase NCI deactivate timeout
@ 2012-01-08 11:43 ilanelias78
2012-01-16 20:27 ` Samuel Ortiz
2012-01-17 11:18 ` Samuel Ortiz
0 siblings, 2 replies; 4+ messages in thread
From: ilanelias78 @ 2012-01-08 11:43 UTC (permalink / raw)
To: aloisio.almeida, lauro.venancio, samuel, linville
Cc: linux-wireless, Ilan Elias
From: Ilan Elias <ilane@ti.com>
Increase NCI deactivate timeout from 5 sec to 30 sec.
NCI deactivate procedure might take a long time,
depending on the local and remote parameters.
Signed-off-by: Ilan Elias <ilane@ti.com>
---
include/net/nfc/nci_core.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/nfc/nci_core.h b/include/net/nfc/nci_core.h
index bccd89e..f4963ea 100644
--- a/include/net/nfc/nci_core.h
+++ b/include/net/nfc/nci_core.h
@@ -47,7 +47,7 @@ enum {
#define NCI_RESET_TIMEOUT 5000
#define NCI_INIT_TIMEOUT 5000
#define NCI_RF_DISC_TIMEOUT 5000
-#define NCI_RF_DEACTIVATE_TIMEOUT 5000
+#define NCI_RF_DEACTIVATE_TIMEOUT 30000
#define NCI_CMD_TIMEOUT 5000
struct nci_dev;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] NFC: Increase NCI deactivate timeout
2012-01-08 11:43 [PATCH] NFC: Increase NCI deactivate timeout ilanelias78
@ 2012-01-16 20:27 ` Samuel Ortiz
2012-01-17 9:42 ` Elias, Ilan
2012-01-17 11:18 ` Samuel Ortiz
1 sibling, 1 reply; 4+ messages in thread
From: Samuel Ortiz @ 2012-01-16 20:27 UTC (permalink / raw)
To: ilanelias78
Cc: aloisio.almeida, lauro.venancio, linville, linux-wireless,
Ilan Elias
Hi Ilan,
On Sun, 2012-01-08 at 13:43 +0200, ilanelias78@gmail.com wrote:
> From: Ilan Elias <ilane@ti.com>
>
> Increase NCI deactivate timeout from 5 sec to 30 sec.
> NCI deactivate procedure might take a long time,
> depending on the local and remote parameters.
30 seconds sounds like a huge delay for receiving a reply to such command.
Would you care explaining how we can get that long of a timeout ?
Cheers,
Samuel.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] NFC: Increase NCI deactivate timeout
2012-01-16 20:27 ` Samuel Ortiz
@ 2012-01-17 9:42 ` Elias, Ilan
0 siblings, 0 replies; 4+ messages in thread
From: Elias, Ilan @ 2012-01-17 9:42 UTC (permalink / raw)
To: Samuel Ortiz
Cc: aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Hi Samuel,
> > Increase NCI deactivate timeout from 5 sec to 30 sec.
> > NCI deactivate procedure might take a long time,
> > depending on the local and remote parameters.
> 30 seconds sounds like a huge delay for receiving a reply to
> such command.
> Would you care explaining how we can get that long of a timeout ?
The controller in the Reader side uses a value called nRETRY (see NFC Forum Digital spec).
This value is an internal implementation, valid range is 2 to 5.
This value determines the number of re-transmissions.
The controller in the Tag side uses a value called FWI - Frame Waiting time Integer (see NFC Forum Digital spec).
This value is an internal implementation, valid range is 1 to 14.
This value determines (via some formula) the FWT - Frame Waiting Time, which is a timout.
Max FWT value can be almost 5sec.
So, the total max timeout can be 5sec for the first packet + 5sec for each of the 5 re-transmissions = 5 + 5x5 = 30 sec.
> Cheers,
> Samuel.
Thanks & BR,
Ilan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NFC: Increase NCI deactivate timeout
2012-01-08 11:43 [PATCH] NFC: Increase NCI deactivate timeout ilanelias78
2012-01-16 20:27 ` Samuel Ortiz
@ 2012-01-17 11:18 ` Samuel Ortiz
1 sibling, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2012-01-17 11:18 UTC (permalink / raw)
To: ilanelias78
Cc: aloisio.almeida, lauro.venancio, linville, linux-wireless,
Ilan Elias
Hi Ilan,
On Sun, 2012-01-08 at 13:43 +0200, ilanelias78@gmail.com wrote:
> From: Ilan Elias <ilane@ti.com>
>
> Increase NCI deactivate timeout from 5 sec to 30 sec.
> NCI deactivate procedure might take a long time,
> depending on the local and remote parameters.
>
> Signed-off-by: Ilan Elias <ilane@ti.com>
Thanks for the explanations:
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Cheers,
Samuel.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-17 11:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-08 11:43 [PATCH] NFC: Increase NCI deactivate timeout ilanelias78
2012-01-16 20:27 ` Samuel Ortiz
2012-01-17 9:42 ` Elias, Ilan
2012-01-17 11:18 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).