From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] rtlwifi: Move pr_fmt macros to a single location
Date: Tue, 17 Jan 2012 20:35:54 -0800 [thread overview]
Message-ID: <1326861354.20922.30.camel@joe2Laptop> (raw)
In-Reply-To: <4f16485c.snp+nOwfRpOtSbfu%Larry.Finger@lwfinger.net>
On Tue, 2012-01-17 at 22:19 -0600, Larry Finger wrote:
> Although the rtlwifi family of devices contains 11 copies of the pr_fmt
> macro, the macro is not defined for all routines that need it. By moving
> the macro to wifi.h, a single copy is available for all routines.
> +++ wireless-testing-new/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
> @@ -43,6 +40,9 @@
> #include "trx.h"
> #include "led.h"
>
> +#include <linux/vmalloc.h>
> +#include <linux/module.h>
You might try sorting out what's actually
necessary to have #included in each file.
vmalloc.h, usb.h and lots of others are already
#included via wifi.h
Another possibility is to add -I..
to the Makefiles so the #includes aren't
specified by relative path.
prev parent reply other threads:[~2012-01-18 4:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 4:19 [PATCH V2] rtlwifi: Move pr_fmt macros to a single location Larry Finger
2012-01-18 4:35 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326861354.20922.30.camel@joe2Laptop \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox