Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: "Luis R. Rodriguez" <mcgrof@frijolero.org>
Cc: linux-wireless@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	wlist@ti.com, idor@ti.com, assaf@ti.com, gil.barak@ti.com
Subject: Re: [PATCH] compat-wireless: check if modprobe exists before using it
Date: Wed, 18 Jan 2012 19:19:48 +0200	[thread overview]
Message-ID: <1326907188.4598.257.camel@cumari> (raw)
In-Reply-To: <CAB=NE6WFFPgQkBvn8uShMVG1+SExUFXfa9dW2jLGad62Sc5dOA@mail.gmail.com>

On Wed, 2012-01-18 at 09:15 -0800, Luis R. Rodriguez wrote: 
> On Wed, Jan 18, 2012 at 12:13 AM, Luciano Coelho <coelho@ti.com> wrote:
> > If you're cross-compiling compat-wireless on a different host, you
> > can't reliably use modprobe.  The host system may not even have
> > modprobe, so it doesn't make sense to run modprobe, unless you're
> > installing the modules on the target machine.
> >
> > The modprobe command was being used unconditionally to set the MADWIFI
> > and OLD_IWL variables.  This commit adds a check to see whether
> > modprobe exists before trying to use.  It also adds a dependency on
> > the modprobe commands to all recipes that rely on it, so we fail more
> > gracefully if modprobe doesn't exist in the system.
> >
> > Reported by: William List <wlist@ti.com>
> > Signed-off-by: Luciano Coelho <coelho@ti.com>
> 
> Good point, I've propagated this into the linux-3.2.y and linux-3.1.y
> branches of compat-wireless as well so that if a new release is made
> the fixes go along with it.

Excellent, thanks dude!

-- 
Cheers,
Luca.


      reply	other threads:[~2012-01-18 17:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18  8:13 [PATCH] compat-wireless: check if modprobe exists before using it Luciano Coelho
2012-01-18 17:15 ` Luis R. Rodriguez
2012-01-18 17:19   ` Luciano Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326907188.4598.257.camel@cumari \
    --to=coelho@ti.com \
    --cc=assaf@ti.com \
    --cc=gil.barak@ti.com \
    --cc=idor@ti.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@frijolero.org \
    --cc=wlist@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox