From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <anamtsov@gmail.com>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: make CQM RSSI support per virtual interface
Date: Thu, 19 Jan 2012 19:06:04 +0100 [thread overview]
Message-ID: <1326996364.3631.9.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CA+XVXff7LdscHL046d0h=s7W9b-YdfLa24EVSed9yrdv0OU75A@mail.gmail.com> (sfid-20120119_183740_990346_DEE58B30)
On Thu, 2012-01-19 at 19:36 +0200, Arik Nemtsov wrote:
> On Thu, Jan 19, 2012 at 10:29, Johannes Berg <johannes@sipsolutions.net> wrote:
> >
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Similar to the previous beacon filtering patch,
> > make CQM RSSI support depend on the flags that
> > the driver set for virtual interfaces.
>
> Up until now we circumvented the issue by having mode specific HW
> flags (e.g. IEEE80211_HW_AP_LINK_PS). Usually the mode of the FW
> determines the HW capabilities and this is enough.
> It also has the advantages of only touching mode-specific code-paths.
>
> Since this is a STA-mode only flag I assume this is something for
> multi-role (multiple stations)?
Yes. I don't know how your multi-role support works, but I'm not really
comfortable with changing the HW flags on the fly (it will work for
these, but not really for many others I think).
johannes
next prev parent reply other threads:[~2012-01-19 18:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 8:29 [PATCH 0/2] per interface configuration Johannes Berg
2012-01-19 8:29 ` [PATCH 1/2] mac80211: make beacon filtering per virtual interface Johannes Berg
2012-01-20 6:22 ` Luciano Coelho
2012-01-19 8:29 ` [PATCH 2/2] mac80211: make CQM RSSI support " Johannes Berg
2012-01-19 11:37 ` Eliad Peller
2012-01-19 12:35 ` Johannes Berg
2012-01-19 13:09 ` Eliad Peller
2012-01-19 17:36 ` Arik Nemtsov
2012-01-19 18:06 ` Johannes Berg [this message]
2012-01-20 6:22 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326996364.3631.9.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anamtsov@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).