From: Johannes Berg <johannes@sipsolutions.net>
To: Sam Leffler <sleffler@chromium.org>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH RESEND] mac80211: support fixed rate packet injection
Date: Fri, 20 Jan 2012 15:17:33 +0100 [thread overview]
Message-ID: <1327069053.9857.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120119182033.5F60358073@lefflers.sfo.corp.google.com> (sfid-20120119_192053_053697_DFEA50C5)
On Thu, 2012-01-12 at 09:53 -0800, Sam Leffler wrote:
> + if (fixed_rate != -1) {
> + struct ieee80211_channel *chan = local->hw.conf.channel;
> + struct ieee80211_supported_band *sband =
> + local->hw.wiphy->bands[chan->band];
> + struct ieee80211_tx_rate *rates = info->control.rates;
> + int i;
> +
> + if (fixed_rate_flags & IEEE80211_TX_RC_MCS) {
> + WARN_ON(!sband->ht_cap.ht_supported);
> + rates[0].idx = fixed_rate;
Unless I missed something, this would be *trivial* to trigger by
injection -- doesn't seem like a good idea to me.
johannes
next prev parent reply other threads:[~2012-01-20 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 17:53 [PATCH RESEND] mac80211: support fixed rate packet injection Sam Leffler
2012-01-20 14:17 ` Johannes Berg [this message]
2012-01-20 18:44 ` Sam Leffler
2012-01-20 19:19 ` Gábor Stefanik
2012-01-20 20:24 ` Johannes Berg
2012-01-20 21:42 ` Sam Leffler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327069053.9857.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sleffler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox