From: Eliad Peller <eliad@wizery.com>
To: Luciano Coelho <coelho@ti.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: [PATCH 10/12] wl12xx: remove 2 unused parameters in wl1271_ps_set_mode()
Date: Mon, 30 Jan 2012 14:00:55 +0200 [thread overview]
Message-ID: <1327924857-1250-11-git-send-email-eliad@wizery.com> (raw)
In-Reply-To: <1327924857-1250-1-git-send-email-eliad@wizery.com>
From: Eyal Shapira <eyal@wizery.com>
cleanup 2 unused parameters of wl1271_ps_set_mode
Signed-off-by: Eyal Shapira <eyal@wizery.com>
Signed-off-by: Eliad Peller <eliad@wizery.com>
---
drivers/net/wireless/wl12xx/debugfs.c | 4 +---
drivers/net/wireless/wl12xx/main.c | 10 +++-------
drivers/net/wireless/wl12xx/ps.c | 2 +-
drivers/net/wireless/wl12xx/ps.h | 2 +-
4 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/debugfs.c b/drivers/net/wireless/wl12xx/debugfs.c
index 156a774..4436851 100644
--- a/drivers/net/wireless/wl12xx/debugfs.c
+++ b/drivers/net/wireless/wl12xx/debugfs.c
@@ -359,9 +359,7 @@ static ssize_t dynamic_ps_timeout_write(struct file *file,
wl12xx_for_each_wlvif_sta(wl, wlvif) {
if (test_bit(WLVIF_FLAG_PSM, &wlvif->flags))
- wl1271_ps_set_mode(wl, wlvif, STATION_AUTO_PS_MODE,
- wlvif->basic_rate, true);
-
+ wl1271_ps_set_mode(wl, wlvif, STATION_AUTO_PS_MODE);
}
wl1271_ps_elp_sleep(wl);
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 2b6dda5..21841d4 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -2444,8 +2444,7 @@ static int wl12xx_config_vif(struct wl1271 *wl, struct wl12xx_vif *wlvif,
if (test_bit(WLVIF_FLAG_STA_ASSOCIATED, &wlvif->flags)) {
wl1271_debug(DEBUG_PSM, "psm enabled");
ret = wl1271_ps_set_mode(wl, wlvif,
- STATION_POWER_SAVE_MODE,
- wlvif->basic_rate, true);
+ STATION_AUTO_PS_MODE);
}
} else if (!(conf->flags & IEEE80211_CONF_PS) &&
test_bit(WLVIF_FLAG_PSM_REQUESTED, &wlvif->flags)) {
@@ -2455,8 +2454,7 @@ static int wl12xx_config_vif(struct wl1271 *wl, struct wl12xx_vif *wlvif,
if (test_bit(WLVIF_FLAG_PSM, &wlvif->flags))
ret = wl1271_ps_set_mode(wl, wlvif,
- STATION_ACTIVE_MODE,
- wlvif->basic_rate, true);
+ STATION_ACTIVE_MODE);
}
if (conf->power_level != wlvif->power_level) {
@@ -3796,9 +3794,7 @@ sta_not_found:
!test_bit(WLVIF_FLAG_PSM, &wlvif->flags)) {
ret = wl1271_ps_set_mode(wl, wlvif,
- STATION_AUTO_PS_MODE,
- wlvif->basic_rate,
- true);
+ STATION_AUTO_PS_MODE);
if (ret < 0)
goto out;
}
diff --git a/drivers/net/wireless/wl12xx/ps.c b/drivers/net/wireless/wl12xx/ps.c
index 60f03c4..5074c2a 100644
--- a/drivers/net/wireless/wl12xx/ps.c
+++ b/drivers/net/wireless/wl12xx/ps.c
@@ -160,7 +160,7 @@ out:
}
int wl1271_ps_set_mode(struct wl1271 *wl, struct wl12xx_vif *wlvif,
- enum wl1271_cmd_ps_mode mode, u32 rates, bool send)
+ enum wl1271_cmd_ps_mode mode)
{
int ret;
u16 timeout = wl->conf.conn.dynamic_ps_timeout;
diff --git a/drivers/net/wireless/wl12xx/ps.h b/drivers/net/wireless/wl12xx/ps.h
index a12052f..5f19d4f 100644
--- a/drivers/net/wireless/wl12xx/ps.h
+++ b/drivers/net/wireless/wl12xx/ps.h
@@ -28,7 +28,7 @@
#include "acx.h"
int wl1271_ps_set_mode(struct wl1271 *wl, struct wl12xx_vif *wlvif,
- enum wl1271_cmd_ps_mode mode, u32 rates, bool send);
+ enum wl1271_cmd_ps_mode mode);
void wl1271_ps_elp_sleep(struct wl1271 *wl);
int wl1271_ps_elp_wakeup(struct wl1271 *wl);
void wl1271_elp_work(struct work_struct *work);
--
1.7.6.401.g6a319
next prev parent reply other threads:[~2012-01-30 11:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 12:00 [PATCH 00/12] wl12xx: update fw api Eliad Peller
2012-01-30 12:00 ` [PATCH 01/12] wl12xx: fw api change - add role_id to set_template Eliad Peller
2012-01-30 19:53 ` Luciano Coelho
2012-01-31 9:40 ` Eliad Peller
2012-01-30 12:00 ` [PATCH 02/12] wl12xx: use dev_role_id for scans Eliad Peller
2012-01-30 12:00 ` [PATCH 03/12] wl12xx: use dev_role_id for sched scan Eliad Peller
2012-01-30 19:47 ` Luciano Coelho
2012-01-30 12:00 ` [PATCH 04/12] wl12xx: fw api change - add role_id to tsf_info Eliad Peller
2012-01-30 12:00 ` [PATCH 05/12] wl12xx: fw api change - update cmd/acx/event enums Eliad Peller
2012-01-30 12:00 ` [PATCH 06/12] wl12xx: Driver-FW API changes Eliad Peller
2012-01-30 19:48 ` Luciano Coelho
2012-01-30 12:00 ` [PATCH 07/12] wl12xx: remove PS management code Eliad Peller
2012-01-30 12:00 ` [PATCH 08/12] wl12xx: add support for HW dynamic PS Eliad Peller
2012-01-30 12:00 ` [PATCH 09/12] wl12xx: add dynamic_ps_timeout debugfs file Eliad Peller
2012-01-30 12:00 ` Eliad Peller [this message]
2012-01-30 12:00 ` [PATCH 11/12] wl12xx: enable/disable BET with AUTO_PS/ACTIVE Eliad Peller
2012-01-30 12:00 ` [PATCH 12/12] wl12xx: change WLVIF_FLAG_PSM name and remove WLVIF_FLAG_PSM_REQUESTED Eliad Peller
2012-01-30 13:29 ` [PATCH 00/12] wl12xx: update fw api Kalle Valo
2012-01-30 13:52 ` Eliad Peller
2012-01-30 13:55 ` Luciano Coelho
2012-01-30 19:59 ` Luciano Coelho
2012-01-31 7:50 ` Kalle Valo
2012-01-31 9:43 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327924857-1250-11-git-send-email-eliad@wizery.com \
--to=eliad@wizery.com \
--cc=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).