From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: Kalle Valo <kvalo@adurom.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 00/12] wl12xx: update fw api
Date: Mon, 30 Jan 2012 21:59:25 +0200 [thread overview]
Message-ID: <1327953565.3626.111.camel@cumari> (raw)
In-Reply-To: <1327931733.3626.72.camel@cumari>
On Mon, 2012-01-30 at 15:55 +0200, Luciano Coelho wrote:
> On Mon, 2012-01-30 at 15:52 +0200, Eliad Peller wrote:
> > On Mon, Jan 30, 2012 at 3:29 PM, Kalle Valo <kvalo@adurom.com> wrote:
> > > Eliad Peller <eliad@wizery.com> writes:
> > >
> > >> The fw api was changed in the latest FWs (6.3.5.0.95 for wl127x
> > >> and 7.3.5.0.95 for wl128x).
> > >>
> > >> Along with some small adjustments, the main changes
> > >> inroduced by this patheset are configuring the
> > >> templates per-role, and moving to IEEE80211_HW_SUPPORTS_DYNAMIC_PS
> > >> mode.
> > >
> > > I didn't look so carefully, but doesn't this break bisect? I mean if you
> > > change the firmware api in small patches wl12xx can't work properly
> > > until all patches are applied, right?
> > >
> > > I would say that a huge patch doing all the necessary changes in one go
> > > is better, even it's ugly.
> > >
> > yes. it will break bisect (although it shouldn't break compilations).
> > i guess it's a matter of taste, but i think keeping the patches
> > manageable is more important than being able to bisect.
>
> I tend to agree with Eliad. If we do all in one go, git blame will be
> horrible.
>
> But it's a good point and I'm not fully convinced what is the best way
> to go. :\
I think this is okay. With the 2 squashes I proposed, there will be
only 3 patches where bisect would be broken.
We could add an info in the first patch and remove it in the last one to
make it clear that we're in the middle of the change.
Does anyone go against this?
--
Cheers,
Luca.
next prev parent reply other threads:[~2012-01-30 19:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 12:00 [PATCH 00/12] wl12xx: update fw api Eliad Peller
2012-01-30 12:00 ` [PATCH 01/12] wl12xx: fw api change - add role_id to set_template Eliad Peller
2012-01-30 19:53 ` Luciano Coelho
2012-01-31 9:40 ` Eliad Peller
2012-01-30 12:00 ` [PATCH 02/12] wl12xx: use dev_role_id for scans Eliad Peller
2012-01-30 12:00 ` [PATCH 03/12] wl12xx: use dev_role_id for sched scan Eliad Peller
2012-01-30 19:47 ` Luciano Coelho
2012-01-30 12:00 ` [PATCH 04/12] wl12xx: fw api change - add role_id to tsf_info Eliad Peller
2012-01-30 12:00 ` [PATCH 05/12] wl12xx: fw api change - update cmd/acx/event enums Eliad Peller
2012-01-30 12:00 ` [PATCH 06/12] wl12xx: Driver-FW API changes Eliad Peller
2012-01-30 19:48 ` Luciano Coelho
2012-01-30 12:00 ` [PATCH 07/12] wl12xx: remove PS management code Eliad Peller
2012-01-30 12:00 ` [PATCH 08/12] wl12xx: add support for HW dynamic PS Eliad Peller
2012-01-30 12:00 ` [PATCH 09/12] wl12xx: add dynamic_ps_timeout debugfs file Eliad Peller
2012-01-30 12:00 ` [PATCH 10/12] wl12xx: remove 2 unused parameters in wl1271_ps_set_mode() Eliad Peller
2012-01-30 12:00 ` [PATCH 11/12] wl12xx: enable/disable BET with AUTO_PS/ACTIVE Eliad Peller
2012-01-30 12:00 ` [PATCH 12/12] wl12xx: change WLVIF_FLAG_PSM name and remove WLVIF_FLAG_PSM_REQUESTED Eliad Peller
2012-01-30 13:29 ` [PATCH 00/12] wl12xx: update fw api Kalle Valo
2012-01-30 13:52 ` Eliad Peller
2012-01-30 13:55 ` Luciano Coelho
2012-01-30 19:59 ` Luciano Coelho [this message]
2012-01-31 7:50 ` Kalle Valo
2012-01-31 9:43 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327953565.3626.111.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).