From: Joe Perches <joe@perches.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: micro-project proposal -- WARN_ON -> WARN_ON_ONCE under drivers/net/wireless
Date: Mon, 30 Jan 2012 13:43:11 -0800 [thread overview]
Message-ID: <1327959791.25132.56.camel@joe2Laptop> (raw)
In-Reply-To: <20120130192811.GD2493@tuxdriver.com>
On Mon, 2012-01-30 at 14:28 -0500, John W. Linville wrote:
> Anyone looking for a little "janitorial" project to do under the
> drivers/net/wireless tree?
>
> find drivers/net/wireless/ -type f -exec grep -H WARN_ON {} \; | \
> grep -v WARN_ON_ONCE | wc -l
> 653
>
> That looks like an awful lot of "WARN_ON" calls. Do all of them
> really need to SPAM the log files every single time they are hit?
> Couldn't a lot of them be WARN_ON_ONCE instead?
>
> Patches welcome...
>
> John
$ grep -rP --include=*.[ch] "\bWARN_ON\s*\(" drivers/net/wireless | \
wc -l
280
There are also:
$ grep -rP --include=*.[ch] "\bWARN_ON\s*\(" drivers/net/wireless | \
grep "define"
drivers/net/wireless/b43legacy/b43legacy.h:# define B43legacy_WARN_ON(x) WARN_ON(x)
drivers/net/wireless/b43/b43.h:# define B43_WARN_ON(x) WARN_ON(x)
Any reason anyone can think of this
shouldn't be a sed conversion?
prev parent reply other threads:[~2012-01-30 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 19:28 micro-project proposal -- WARN_ON -> WARN_ON_ONCE under drivers/net/wireless John W. Linville
2012-01-30 21:43 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327959791.25132.56.camel@joe2Laptop \
--to=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox