From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 01/10] wl12xx: fw api change - add role_id to set_template
Date: Tue, 31 Jan 2012 12:01:51 +0200 [thread overview]
Message-ID: <1328004111.3626.159.camel@cumari> (raw)
In-Reply-To: <1328003845-3926-2-git-send-email-eliad@wizery.com>
On Tue, 2012-01-31 at 11:57 +0200, Eliad Peller wrote:
> The set_template commands now takes the role_id as
> parameter.
>
> Usually, we'll use the vif's main role_id.
> However, sometimes we'll want to use
> wlvif->dev_role_id instead of wlvif->role_id,
> so pass the wanted role_id as param.
>
> Update WL127X_FW_NAME/WL128X_FW_NAME.
>
> (This commit starts a series of fw update patches,
> and changes the start() callback to return an error
> in order to prevent the use of the driver during the
> transition. This change will be reverted in the
> last patch of series)
Is it really necessary to prevent boot until the last patch in this
series? Is the PS stuff really mandatory? I was thinking that after 4/10
we could already re-enable it.
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
> v2: return -EBUSY on start(), commit message
-EBUSY? Maybe -EOPNOTSUPP would be better? -EBUSY usually means that you
should try again later. But never mind, this is just a transition phase
anyway. ;)
--
Cheers,
Luca.
next prev parent reply other threads:[~2012-01-31 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 9:57 [PATCH v2 00/10] wl12xx: update fw api Eliad Peller
2012-01-31 9:57 ` [PATCH v2 01/10] wl12xx: fw api change - add role_id to set_template Eliad Peller
2012-01-31 10:01 ` Luciano Coelho [this message]
2012-01-31 9:57 ` [PATCH v2 02/10] wl12xx: use dev_role_id for scans Eliad Peller
2012-01-31 9:57 ` [PATCH v2 03/10] wl12xx: fw api change - add role_id to tsf_info Eliad Peller
2012-01-31 9:57 ` [PATCH v2 04/10] wl12xx: fw api change - update cmd/acx/event enums Eliad Peller
2012-01-31 9:57 ` [PATCH v2 05/10] wl12xx: remove PS management code Eliad Peller
2012-01-31 9:57 ` [PATCH v2 06/10] wl12xx: add support for HW dynamic PS Eliad Peller
2012-01-31 9:57 ` [PATCH v2 07/10] wl12xx: add dynamic_ps_timeout debugfs file Eliad Peller
2012-01-31 9:57 ` [PATCH v2 08/10] wl12xx: remove 2 unused parameters in wl1271_ps_set_mode() Eliad Peller
2012-01-31 9:57 ` [PATCH v2 09/10] wl12xx: enable/disable BET with AUTO_PS/ACTIVE Eliad Peller
2012-01-31 9:57 ` [PATCH v2 10/10] wl12xx: change WLVIF_FLAG_PSM name and remove WLVIF_FLAG_PSM_REQUESTED Eliad Peller
2012-02-15 10:15 ` [PATCH v2 00/10] wl12xx: update fw api Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328004111.3626.159.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox