Re: [PATCH 2/2] cleanup modprobe calls

[Luciano Coelho <coelho@ti.com>]

On Fri, 2012-02-03 at 09:13 -0500, Richard Farina wrote: 
> On 02/03/12 00:57, Luciano Coelho wrote:
> > On Thu, 2012-02-02 at 21:48 -0500, Rick Farina wrote: 
> >> There were a lot of needless calls to "modprobe -l <drivername>" and even more confusingly $(MODPROBE).
> >> None of this is needed on a modern distro, and it errors on when modprobe -l is removed (such as KMOD in Arch Linux)
> >>
> >> Signed-of-By: Rick Farina <sidhayn@gmail.com>
> >> ---
> > I agree with this.  The modprobes are just there in order to list which
> > of the relevant modules you have in your system.  There is little value
> > in this and, if considered really necessary, there surely must be other
> > ways to find out?
> >
> Although I've never liked all this scrolling, I would have recoded it
> rather than removed it if I knew how.  At the present time there is no
> way which I know to replicate this functionality. I suppose a find
> statement could be added but honestly I just don't see it as necessary,
> or any cleaner.

Well, at least we should use something else then $(MODPROBE) -l.  It
would be nice to make it more generic.  "-l" is a modprobe specific
option, maybe it could be moved to the variable itself so it could be
changed for another command with the same effect? Maybe change it to
$(FINDMODULE) and assign it to "modprobe -l" by default?

-- 
Cheers,
Luca.