From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@frijolero.org>
Cc: "Goldenshtein, Victor" <victorg@ti.com>,
linux-wireless@vger.kernel.org, kgiori@qca.qualcomm.com,
zefir.kurtisi@neratec.com, adrian.chadd@gmail.com, j@w1.fi,
coelho@ti.com, assaf@ti.com, yoni.divinsky@ti.com, igalc@ti.com,
adrian@freebsd.org, nbd@nbd.name
Subject: Re: [RFC 7/9] nl80211/cfg80211: add DFS feature flag
Date: Mon, 13 Feb 2012 11:28:08 +0100 [thread overview]
Message-ID: <1329128888.3365.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAB=NE6WkArbBkiT6A4eEKEo6k2EJ2SsxjoNoPHp5BDWZNR3t8g@mail.gmail.com> (sfid-20120210_001212_463456_F8632DEE)
On Thu, 2012-02-09 at 15:11 -0800, Luis R. Rodriguez wrote:
> On Thu, Feb 2, 2012 at 8:08 AM, Goldenshtein, Victor <victorg@ti.com> wrote:
> > On Tue, Jan 31, 2012 at 7:52 AM, Johannes Berg
> > <johannes@sipsolutions.net> wrote:
> >> On 1/26/2012 4:38 AM, Victor Goldenshtein wrote:
> >>>
> >>> +static int nl80211_put_feature_flags(struct wiphy *wiphy,
> >>> + struct sk_buff *msg)
> >>> +{
> >>> + if (wiphy->flags& WIPHY_FLAG_SUPPORTS_DFS)
> >>>
> >>> + wiphy->features |= NL80211_FEATURE_DFS;
> >>> +
> >>> +
> >>> + NLA_PUT_U32(msg, NL80211_ATTR_FEATURE_FLAGS, wiphy->features);
> >>> +
> >>> + return 0;
> >>> +nla_put_failure:
> >>> + return -ENOBUFS;
> >>> +}
> >>
> >>
> >> I think you misunderstood the new feature flags -- they're supposed to be
> >> set by the driver directly, not indirectly via wiphy->flags.
> >>
> >
> > yep, I guess you're right.
>
> While a it, consider adding one for the requirement of sending the
> channel switch announcement within mac80211, not the driver. In that
> case, although a DFS feature may be available in the driver, DFS
> should not be enabled on the driver through nl80211 unless that
> feature gets implemented in mac80211.
That, however, should be feature flag in mac80211, not cfg80211 (wiphy),
and in fact I think it can probably be done by checking if the low-level
function is there instead.
johannes
next prev parent reply other threads:[~2012-02-13 10:28 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 12:37 [RFC 0/9] nl/cfg/mac80211: add DFS master ability Victor Goldenshtein
2012-01-26 12:37 ` [RFC 1/9] nl80211/cfg80211: add radar detection command/event Victor Goldenshtein
2012-01-31 5:39 ` Johannes Berg
2012-02-02 16:06 ` Goldenshtein, Victor
2012-02-09 22:02 ` Luis R. Rodriguez
2012-02-15 16:45 ` Goldenshtein, Victor
2012-01-26 12:37 ` [RFC 2/9] mac80211: " Victor Goldenshtein
2012-01-31 5:42 ` Johannes Berg
2012-02-02 16:06 ` Goldenshtein, Victor
2012-01-26 12:37 ` [RFC 3/9] nl80211/cfg80211: add ability to enable TX on op-channel Victor Goldenshtein
2012-01-31 5:43 ` Johannes Berg
2012-02-02 16:06 ` Goldenshtein, Victor
[not found] ` <4F2B18AA.90809@neratec.com>
2012-02-06 11:16 ` zefir.kurtisi
2012-02-06 13:01 ` Goldenshtein, Victor
2012-02-06 14:48 ` Zefir Kurtisi
2012-02-06 15:34 ` Goldenshtein, Victor
2012-02-06 21:01 ` Johannes Berg
2012-02-09 21:04 ` Goldenshtein, Victor
2012-02-09 22:34 ` Luis R. Rodriguez
2012-02-15 16:45 ` Goldenshtein, Victor
2012-03-15 9:37 ` Goldenshtein, Victor
2012-03-15 21:04 ` Coelho, Luciano
2012-01-26 12:37 ` [RFC 4/9] mac80211: " Victor Goldenshtein
2012-01-31 5:45 ` Johannes Berg
2012-02-02 16:06 ` Goldenshtein, Victor
2012-02-09 22:36 ` Luis R. Rodriguez
2012-02-15 16:45 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 5/9] nl80211/cfg80211: add ap channel switch command/event Victor Goldenshtein
2012-01-31 5:46 ` Johannes Berg
2012-02-02 16:07 ` Goldenshtein, Victor
2012-02-09 22:53 ` Luis R. Rodriguez
2012-02-15 16:46 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 6/9] mac80211: " Victor Goldenshtein
2012-01-31 5:51 ` Johannes Berg
2012-02-02 16:07 ` Goldenshtein, Victor
2012-02-06 21:03 ` Johannes Berg
2012-02-09 20:02 ` Goldenshtein, Victor
2012-02-09 23:04 ` Luis R. Rodriguez
2012-02-15 16:46 ` Goldenshtein, Victor
2012-02-09 23:06 ` Luis R. Rodriguez
2012-02-15 16:46 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 7/9] nl80211/cfg80211: add DFS feature flag Victor Goldenshtein
2012-01-31 5:52 ` Johannes Berg
2012-02-02 16:08 ` Goldenshtein, Victor
2012-02-09 23:11 ` Luis R. Rodriguez
2012-02-13 10:28 ` Johannes Berg [this message]
2012-02-15 17:01 ` Goldenshtein, Victor
2012-02-15 16:46 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 8/9] mac80211: add DFS capabilities flag Victor Goldenshtein
2012-01-31 5:52 ` Johannes Berg
2012-02-02 16:08 ` Goldenshtein, Victor
2012-01-26 12:38 ` [RFC 9/9] mac80211: add DFS support to monitor interface Victor Goldenshtein
2012-01-26 14:10 ` Christian Lamparter
2012-01-26 15:50 ` Goldenshtein, Victor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329128888.3365.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=adrian.chadd@gmail.com \
--cc=adrian@freebsd.org \
--cc=assaf@ti.com \
--cc=coelho@ti.com \
--cc=igalc@ti.com \
--cc=j@w1.fi \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@frijolero.org \
--cc=nbd@nbd.name \
--cc=victorg@ti.com \
--cc=yoni.divinsky@ti.com \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).