Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: DELBA processed in workqueue too slow?
Date: Tue, 14 Feb 2012 11:59:31 +0100	[thread overview]
Message-ID: <1329217171.3941.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAGXE3d-ydmV8qrtihSHCNBtkTxT8M=JCACBZFuP+Ne3cQ1WVow@mail.gmail.com> (sfid-20120206_164853_205520_EC6E0AD1)

On Mon, 2012-02-06 at 16:48 +0100, Helmut Schaa wrote:
> Hi,
> 
> since all action frames are handled in the iface workqueue the following
> situation can cause problems on slow devices in AP mode:
> 
> - data stream AP -> STA with established TX BA session
> - peer sends a DELBA to tear the APs TX BA session down
> - new frames are still send as AMPDU but the receiver doesn't BlockAck
>   them anymore since it assumes the BA session is already teared down.
> - DELBA gets processed

> Hence, most frames between receiving the DELBA and actually processing
> it are basically lost. This can easily make TCP streams getting stuck for a
> few seconds :(

Why are they lost? They haven't been acknowledged so wouldn't they be
retransmitted?

In any case, it seems the easiest solution may be to stop queues? But to
really make this fool-proof you'd also have to tell the driver to
release all its internal buffers -- and you're never going to solve the
race completely.

johannes


  reply	other threads:[~2012-02-14 10:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 15:48 DELBA processed in workqueue too slow? Helmut Schaa
2012-02-14 10:59 ` Johannes Berg [this message]
2012-02-14 12:46   ` Helmut Schaa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329217171.3941.10.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=helmut.schaa@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox