linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] wl12xx: remove some dead code in wl1271_plt_init()
@ 2012-02-08  9:20 Dan Carpenter
  2012-02-15 10:29 ` Luciano Coelho
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-02-08  9:20 UTC (permalink / raw)
  To: Luciano Coelho
  Cc: John W. Linville, Shahar Levi, linux-wireless, kernel-janitors

"ret" has already been checked at this point, and we don't need to check
it again.  This was left around from a previous patch 49d750ca14
"wl12xx: 1281/1283 support - New radio structs and functions".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index f8748ce..96d90e7 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -672,8 +672,6 @@ static int wl1271_plt_init(struct wl1271 *wl)
 		if (ret < 0)
 			return ret;
 	}
-	if (ret < 0)
-		return ret;
 
 	/* Chip-specific initializations */
 	ret = wl1271_chip_specific_init(wl);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] wl12xx: remove some dead code in wl1271_plt_init()
  2012-02-08  9:20 [patch] wl12xx: remove some dead code in wl1271_plt_init() Dan Carpenter
@ 2012-02-15 10:29 ` Luciano Coelho
  0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2012-02-15 10:29 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: John W. Linville, Shahar Levi, linux-wireless, kernel-janitors

On Wed, 2012-02-08 at 12:20 +0300, Dan Carpenter wrote: 
> "ret" has already been checked at this point, and we don't need to check
> it again.  This was left around from a previous patch 49d750ca14
> "wl12xx: 1281/1283 support - New radio structs and functions".
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.  Thanks, Dan!

-- 
Cheers,
Luca.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-15 10:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-08  9:20 [patch] wl12xx: remove some dead code in wl1271_plt_init() Dan Carpenter
2012-02-15 10:29 ` Luciano Coelho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).