From: Joe Perches <joe@perches.com>
To: Luis Felipe Strano Moraes <lfelipe@profusion.mobi>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
davem@davemloft.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cleaning up code formatting errors in net/wireless pointed out by checkpatch.
Date: Fri, 17 Feb 2012 10:45:44 -0800 [thread overview]
Message-ID: <1329504344.584.18.camel@joe2Laptop> (raw)
In-Reply-To: <1329492603-3972-1-git-send-email-lfelipe@profusion.mobi>
On Fri, 2012-02-17 at 07:30 -0800, Luis Felipe Strano Moraes wrote:
> These are mostly minor changes and they are being sent as one patch only in
> order to cause the smallest amount of disruption.
[]
> diff --git a/net/wireless/core.c b/net/wireless/core.c
[]
> @@ -668,7 +668,7 @@ void wiphy_unregister(struct wiphy *wiphy)
> mutex_lock(&rdev->devlist_mtx);
> __count = rdev->opencount;
> mutex_unlock(&rdev->devlist_mtx);
> - __count == 0;}));
> + __count == 0; }));
Inline statement expressions are pretty unusual
for kernel sources. Normally these are used via
macro.
I'd try to make the statement expression visually
distinct. Something like:
wait_event(rdev->dev_wait,
({
int __count;
mutex_lock(&rdev->devlist_mtx);
__count = rdev->opencount;
mutex_unlock(&rdev->devlist_mtx);
__count == 0;
})
);
next prev parent reply other threads:[~2012-02-17 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 15:30 [PATCH] Cleaning up code formatting errors in net/wireless pointed out by checkpatch Luis Felipe Strano Moraes
2012-02-17 15:47 ` David Laight
2012-02-17 15:56 ` Luis Felipe Strano Moraes
2012-02-17 18:45 ` Joe Perches [this message]
2012-02-17 19:06 ` Stephen Hemminger
2012-02-20 10:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329504344.584.18.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=lfelipe@profusion.mobi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).