From: Joe Perches <joe@perches.com>
To: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 04/26] iwlwifi: trace debug messages
Date: Fri, 17 Feb 2012 12:36:36 -0800 [thread overview]
Message-ID: <1329510996.584.39.camel@joe2Laptop> (raw)
In-Reply-To: <1329506034-1394-5-git-send-email-wey-yi.w.guy@intel.com>
On Fri, 2012-02-17 at 11:13 -0800, Wey-Yi Guy wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Make iwlwifi record all debug messages into
> tracing, even if debug_level is not enabled.
[]
> diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.c b/drivers/net/wireless/iwlwifi/iwl-debug.c
[]
> +#define __iwl_fn(fn) \
> +void __iwl_ ##fn(struct device *dev, const char *fmt, ...) \
> +{ \
> + struct va_format vaf = { \
> + .fmt = fmt, \
> + }; \
Using initializers like this takes 1 more line
than the form I believe is used everywhere else.
> + va_list args; \
> + \
> + va_start(args, fmt); \
> + vaf.va = &args; \
struct va_format vaf;
va_start(args, fmt);
vaf.fmt = fmt;
vaf.va = &args;
next prev parent reply other threads:[~2012-02-17 20:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 19:13 [PATCH 00/26] update for 3.4: iwlwifi 2012-02-17 Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 01/26] iwlwifi: log as error when error detected Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 02/26] iwlwifi: testmode new indirect RW API Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 03/26] iwlwifi: added reply data to testmode HCMD send Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 04/26] iwlwifi: trace debug messages Wey-Yi Guy
2012-02-17 20:36 ` Joe Perches [this message]
2012-02-17 19:13 ` [PATCH 05/26] iwlwifi: move workqueue to priv Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 06/26] iwlwifi: give PCIe its own lock Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 07/26] iwlwifi: create iwl_nic structure Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 08/26] iwlwifi: move ucode_ver to iwl_nic Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 09/26] iwlwifi: move fw_index from iwl_priv " Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 10/26] iwlwifi: move firmware_name " Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 11/26] iwlwifi: move firmware_loading_complete " Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 12/26] iwlwifi: Move ucode pointers to iwl_fw Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 13/26] iwlwifi: change args to ucode routines Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 14/26] iwlwifi: kill iwl_down and s/__iwl_down/iwl_down Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 15/26] iwlwifi: iwl_set_hw_params returns always 0 Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 16/26] iwlwifi: use enhance_sensitivity from iwl_fw Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 17/26] iwlwifi: fixes to testmode indirect access Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 18/26] iwlwifi: send testmode hcmd reply with rx header Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 19/26] iwlwifi: document the transport layer Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 20/26] iwlwifi: move event and err pointers to iwl_nic Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 21/26] iwlwifi: the transport knows its state Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 22/26] iwlwifi: changes args to iwl_nic for firmware operations Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 23/26] iwlwifi: save ucode capabilities in iwl_fw Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 24/26] iwlwifi: SRAM size moves from hw_params to cfg Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 25/26] iwlwifi: remove un-necessary return Wey-Yi Guy
2012-02-17 19:13 ` [PATCH 26/26] iwlwifi: enable receiving beacons when not associated Wey-Yi Guy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329510996.584.39.camel@joe2Laptop \
--to=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox