From: Luciano Coelho <coelho@ti.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-wireless@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: linux-firmware: pull-request wl12xx 2012-02-17
Date: Sun, 19 Feb 2012 13:50:50 +0200 [thread overview]
Message-ID: <1329652250.3253.30.camel@cumari> (raw)
In-Reply-To: <1329615009.3258.57.camel@deadeye>
[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]
On Sun, 2012-02-19 at 01:30 +0000, Ben Hutchings wrote:
> On Fri, 2012-02-17 at 17:41 +0200, Luciano Coelho wrote:
> > Hi Ben,
> >
> > Please pull the latest firmwares for the wl12xx driver. These are new
> > firmwares that are necessary to use the latest driver version, in which
> > the host/fw API has changed. We also updated our licence file.
> >
> > Please let me know if there are any problems.
>
> There are.
:)
> [...]
> > diff --git a/LICENCE.ti-connectivity b/LICENCE.ti-connectivity
> > index 085f6c7..da80b62 100644
> > --- a/LICENCE.ti-connectivity
> > +++ b/LICENCE.ti-connectivity
> > @@ -1,151 +1,46 @@
> [...]
> > + 1 TECHNOLOGY AND SOFTWARE PUBLICLY AVAILABLE
> > + 2 SOFTWARE LICENSE
> > + 3
>
> What's with the line numbers here?
I don't really know, it's ugly, but that's what we got from legal. I
saw it but didn't dare change, I'll recheck with legal to see if that is
really required or not.
> [...]
> > diff --git a/WHENCE b/WHENCE
> > index 804c91f..0596204 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> [...]
> > + Single-role: wl127x-fw-4-sr.bin 6.3.5.0.98
> > + Multi-role: wl127x-fw-4-mr.bin 6.5.2.0.15
> > + PLT: wl127x-fw-4-plt.bin 6.3.5.0.98
> > + Single-role: wl128x-fw-4-sr.bin 7.3.5.0.98
> > + Multi-role: wl128x-fw-4-mr.bin 7.5.2.0.15
> > + PLT: wl128x-fw-4-plt.bin 7.3.5.0.98
> [...]
>
> This is not the correct format for version information. I'm going to
> insist that for the new files you put a 'Version' field under each
> 'File' field. Please also convert the existing version information in a
> separate commit.
Okay, I'll use the correct format and resend. I'll also add a patch to
fix the existing ones.
I'm the new "pusher" of firmwares from TI, so please bear with me while
I adapt and learn the correct rules for linux-firmware.git. ;)
Thanks a lot for the comments!
--
Cheers,
Luca.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-19 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 15:41 linux-firmware: pull-request wl12xx 2012-02-17 Luciano Coelho
2012-02-19 1:30 ` Ben Hutchings
2012-02-19 11:50 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329652250.3253.30.camel@cumari \
--to=coelho@ti.com \
--cc=ben@decadent.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).