From: Joe Perches <joe@perches.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org
Subject: Re: [PATCH 25/26] ath9k_hw: MCI whitespace/debug cleanup
Date: Wed, 22 Feb 2012 00:38:11 -0800 [thread overview]
Message-ID: <1329899891.5143.34.camel@joe2Laptop> (raw)
In-Reply-To: <20292.38229.300584.953289@gargle.gargle.HOWL>
On Wed, 2012-02-22 at 12:42 +0530, Sujith Manoharan wrote:
> This patch fixes indentation and the general coding style
> in ar9003_mci.c. Also, minimize the amount of debug log
> output generated by MCI.
[]
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mci.c b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
[]
> @@ -35,13 +35,10 @@ static int ar9003_mci_wait_for_interrupt(struct ath_hw *ah, u32 address,
> struct ath_common *common = ath9k_hw_common(ah);
>
> while (time_out) {
> -
> if (REG_READ(ah, address) & bit_position) {
> -
> REG_WRITE(ah, address, bit_position);
A for loop with a test/continue would reduce indentation.
Might fix a bug too if timeout is ever negative.
for (; timeout > 0; udelay(10), timeout -= 10) {
if (!(REG_READ(ah, address) & bit_position))
continue;
etc...
next prev parent reply other threads:[~2012-02-22 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 7:12 [PATCH 25/26] ath9k_hw: MCI whitespace/debug cleanup Sujith Manoharan
2012-02-22 8:38 ` Joe Perches [this message]
2012-02-22 9:15 ` Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329899891.5143.34.camel@joe2Laptop \
--to=joe@perches.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox