From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: use proper sub_if_data on suspend path
Date: Thu, 23 Feb 2012 10:27:22 +0100 [thread overview]
Message-ID: <1329989242.3448.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1329959868-10989-1-git-send-email-kubakici@wp.pl>
On Thu, 2012-02-23 at 02:17 +0100, Jakub Kicinski wrote:
> Use interface data from sta instead of invalid pointer
> to list head in calls to drv_sta_state.
Good catch, thanks
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
> ---
> net/mac80211/pm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/pm.c b/net/mac80211/pm.c
> index 2b53a53..ef8eba1 100644
> --- a/net/mac80211/pm.c
> +++ b/net/mac80211/pm.c
> @@ -102,7 +102,7 @@ int __ieee80211_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
>
> state = sta->sta_state;
> for (; state > IEEE80211_STA_NOTEXIST; state--)
> - WARN_ON(drv_sta_state(local, sdata, sta,
> + WARN_ON(drv_sta_state(local, sta->sdata, sta,
> state, state - 1));
> }
>
prev parent reply other threads:[~2012-02-23 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 1:17 [PATCH] mac80211: use proper sub_if_data on suspend path Jakub Kicinski
2012-02-23 9:27 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329989242.3448.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kubakici@wp.pl \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).