* [PATCH] mac80211: use proper sub_if_data on suspend path
@ 2012-02-23 1:17 Jakub Kicinski
2012-02-23 9:27 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2012-02-23 1:17 UTC (permalink / raw)
To: johannes; +Cc: linville, linux-wireless, Jakub Kicinski
Use interface data from sta instead of invalid pointer
to list head in calls to drv_sta_state.
Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
---
net/mac80211/pm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/pm.c b/net/mac80211/pm.c
index 2b53a53..ef8eba1 100644
--- a/net/mac80211/pm.c
+++ b/net/mac80211/pm.c
@@ -102,7 +102,7 @@ int __ieee80211_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
state = sta->sta_state;
for (; state > IEEE80211_STA_NOTEXIST; state--)
- WARN_ON(drv_sta_state(local, sdata, sta,
+ WARN_ON(drv_sta_state(local, sta->sdata, sta,
state, state - 1));
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: use proper sub_if_data on suspend path
2012-02-23 1:17 [PATCH] mac80211: use proper sub_if_data on suspend path Jakub Kicinski
@ 2012-02-23 9:27 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2012-02-23 9:27 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: linville, linux-wireless
On Thu, 2012-02-23 at 02:17 +0100, Jakub Kicinski wrote:
> Use interface data from sta instead of invalid pointer
> to list head in calls to drv_sta_state.
Good catch, thanks
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
> ---
> net/mac80211/pm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/pm.c b/net/mac80211/pm.c
> index 2b53a53..ef8eba1 100644
> --- a/net/mac80211/pm.c
> +++ b/net/mac80211/pm.c
> @@ -102,7 +102,7 @@ int __ieee80211_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
>
> state = sta->sta_state;
> for (; state > IEEE80211_STA_NOTEXIST; state--)
> - WARN_ON(drv_sta_state(local, sdata, sta,
> + WARN_ON(drv_sta_state(local, sta->sdata, sta,
> state, state - 1));
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-23 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23 1:17 [PATCH] mac80211: use proper sub_if_data on suspend path Jakub Kicinski
2012-02-23 9:27 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).